* -git mips defconfig compile error
@ 2007-10-14 13:19 Adrian Bunk
2007-10-15 9:55 ` Ralf Baechle
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2007-10-14 13:19 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, linux-kernel
Commit 05dc8c02bf40090e9ed23932b1980ead48eb8870 causes the following
compile error with the mips defconfig:
<-- snip -->
...
CC drivers/video/logo/logo.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c: In function 'fb_find_logo':
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: 'mips_machgroup' undeclared (first use in this function)
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: (Each undeclared identifier is reported only once
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: for each function it appears in.)
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: 'MACH_GROUP_SGI' undeclared (first use in this function)
make[4]: *** [drivers/video/logo/logo.o] Error 1
<-- snip -->
It seems the drivers/net/jazzsonic.c and drivers/video/logo/logo.c parts
that are part of the corresponding commit in the mips git tree got lost
somewhere.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: -git mips defconfig compile error
2007-10-14 13:19 -git mips defconfig compile error Adrian Bunk
@ 2007-10-15 9:55 ` Ralf Baechle
2007-10-15 16:19 ` Maciej W. Rozycki
0 siblings, 1 reply; 4+ messages in thread
From: Ralf Baechle @ 2007-10-15 9:55 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-mips, linux-kernel
On Sun, Oct 14, 2007 at 03:19:48PM +0200, Adrian Bunk wrote:
> Commit 05dc8c02bf40090e9ed23932b1980ead48eb8870 causes the following
> compile error with the mips defconfig:
>
> <-- snip -->
>
> ...
> CC drivers/video/logo/logo.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c: In function 'fb_find_logo':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: 'mips_machgroup' undeclared (first use in this function)
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: (Each undeclared identifier is reported only once
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: for each function it appears in.)
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c:91: error: 'MACH_GROUP_SGI' undeclared (first use in this function)
> make[4]: *** [drivers/video/logo/logo.o] Error 1
>
> <-- snip -->
>
> It seems the drivers/net/jazzsonic.c and drivers/video/logo/logo.c parts
> that are part of the corresponding commit in the mips git tree got lost
> somewhere.
The logo.c bit I've sent out a few weeks ago so I'm just waiting for that
patch to resurface at the other end of the wormhole.
The jazzsonic breakage was caused by the not very well done "[NET]:
Introduce and use print_mac() and DECLARE_MAC_BUF()" patch aka
0795af5729b18218767fab27c44b1384f72dc9ad.
(No need to mail me about build failures of default configurations; there
is an autobuilder building them regularly ...)
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: -git mips defconfig compile error
2007-10-15 9:55 ` Ralf Baechle
@ 2007-10-15 16:19 ` Maciej W. Rozycki
2007-10-15 17:45 ` Ralf Baechle
0 siblings, 1 reply; 4+ messages in thread
From: Maciej W. Rozycki @ 2007-10-15 16:19 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Adrian Bunk, linux-mips, linux-kernel
On Mon, 15 Oct 2007, Ralf Baechle wrote:
> The logo.c bit I've sent out a few weeks ago so I'm just waiting for that
> patch to resurface at the other end of the wormhole.
Hmm, I would have waited for this to happen before committing the change
depending on it not to keep things known-broken then... That's what I do
with my bits, e.g. I have an update to platform code waiting till
sb1250-mac.c changes come over here.
Maciej
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: -git mips defconfig compile error
2007-10-15 16:19 ` Maciej W. Rozycki
@ 2007-10-15 17:45 ` Ralf Baechle
0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2007-10-15 17:45 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: Adrian Bunk, linux-mips, linux-kernel
On Mon, Oct 15, 2007 at 05:19:43PM +0100, Maciej W. Rozycki wrote:
> > The logo.c bit I've sent out a few weeks ago so I'm just waiting for that
> > patch to resurface at the other end of the wormhole.
>
> Hmm, I would have waited for this to happen before committing the change
> depending on it not to keep things known-broken then... That's what I do
> with my bits, e.g. I have an update to platform code waiting till
> sb1250-mac.c changes come over here.
Na, much more trivial. After a little looking into what went wrong I
found that I meant to strip only the jazzsonic segment because of another
jazzsonic patch from Fleedwood. But I stripped the logo.c bit as well.
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-10-15 17:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-14 13:19 -git mips defconfig compile error Adrian Bunk
2007-10-15 9:55 ` Ralf Baechle
2007-10-15 16:19 ` Maciej W. Rozycki
2007-10-15 17:45 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox