* tuner-core.c:fe_has_signal() can returne uninitialized value
@ 2007-10-14 17:51 Adrian Bunk
2007-10-14 21:16 ` Michael Krufky
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-10-14 17:51 UTC (permalink / raw)
To: Michael Krufky, Mauro Carvalho Chehab; +Cc: v4l-dvb-maintainer, linux-kernel
Commit 1f5ef19779df2c2f75870332b37dd3004c08a515 added the following
function to drivers/media/video/tuner-core.c:
<-- snip -->
static int fe_has_signal(struct tuner *t)
{
struct dvb_tuner_ops *fe_tuner_ops = &t->fe.ops.tuner_ops;
u16 strength;
if (fe_tuner_ops->get_rf_strength)
fe_tuner_ops->get_rf_strength(&t->fe, &strength);
return strength;
}
<-- snip -->
If (!fe_tuner_ops->get_rf_strength) this function returns the value of
an uninitialized variable.
Spotted by the Coverity checker.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: tuner-core.c:fe_has_signal() can returne uninitialized value 2007-10-14 17:51 tuner-core.c:fe_has_signal() can returne uninitialized value Adrian Bunk @ 2007-10-14 21:16 ` Michael Krufky 0 siblings, 0 replies; 2+ messages in thread From: Michael Krufky @ 2007-10-14 21:16 UTC (permalink / raw) To: Adrian Bunk; +Cc: Mauro Carvalho Chehab, v4l-dvb-maintainer, linux-kernel Adrian Bunk wrote: > Commit 1f5ef19779df2c2f75870332b37dd3004c08a515 added the following > function to drivers/media/video/tuner-core.c: > > <-- snip --> > > static int fe_has_signal(struct tuner *t) > { > struct dvb_tuner_ops *fe_tuner_ops = &t->fe.ops.tuner_ops; > u16 strength; > > if (fe_tuner_ops->get_rf_strength) > fe_tuner_ops->get_rf_strength(&t->fe, &strength); > > return strength; > } > > <-- snip --> > > > If (!fe_tuner_ops->get_rf_strength) this function returns the value of > an uninitialized variable. > > Spotted by the Coverity checker. > Thank you, Adrian. I've fixed this in my tree: http://linuxtv.org/hg/~mkrufky/v4l-dvb/rev/101ca558a777 Mauro, please pull from: http://linuxtv.org/hg/~mkrufky/v4l-dvb for: - tuner-core.c: fe_has_signal() can return uninitialized value tuner-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Please send this to Linus for 2.6.24 Regards, Mike ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-14 21:16 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-10-14 17:51 tuner-core.c:fe_has_signal() can returne uninitialized value Adrian Bunk 2007-10-14 21:16 ` Michael Krufky
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox