* [PATCH] skb->tail in ibm_newemac should be skb_tail_pointer()
@ 2007-10-14 18:20 Al Viro
0 siblings, 0 replies; only message in thread
From: Al Viro @ 2007-10-14 18:20 UTC (permalink / raw)
To: Linus Torvalds; +Cc: davem, jgarzik, linux-kernel
... since that sucker is not 32bit-only and on 64bit skb->tail is an
offset, not a pointer.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
drivers/net/ibm_newemac/core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
index 8ea5009..7a5aabd 100644
--- a/drivers/net/ibm_newemac/core.c
+++ b/drivers/net/ibm_newemac/core.c
@@ -1534,7 +1534,7 @@ static inline int emac_rx_sg_append(struct emac_instance *dev, int slot)
dev_kfree_skb(dev->rx_sg_skb);
dev->rx_sg_skb = NULL;
} else {
- cacheable_memcpy(dev->rx_sg_skb->tail,
+ cacheable_memcpy(skb_tail_pointer(dev->rx_sg_skb),
dev->rx_skb[slot]->data, len);
skb_put(dev->rx_sg_skb, len);
emac_recycle_rx_skb(dev, slot, len);
--
1.5.3.GIT
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-10-14 18:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-14 18:20 [PATCH] skb->tail in ibm_newemac should be skb_tail_pointer() Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox