From: Christoph Hellwig <hch@infradead.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove GPL restriction from set_dumpable()
Date: Sun, 14 Oct 2007 22:03:41 +0100 [thread overview]
Message-ID: <20071014210341.GA30029@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0710141257030.20620@jikos.suse.cz>
On Sun, Oct 14, 2007 at 01:04:31PM +0200, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> remove GPL restriction from set_dumpable()
>
> Commit 6c5d5238 introduced a set_dumpable() function that replaced the
> direct access to mm_struct->dumpable. I don't think there is any reason to
> restrict this function to EXPORT_SYMBOL_GPL() -- previously any module
> could modify current->mm->dumpable without any resitrictions, so it makes
> a little sense to turn this into 'internal interface' at once.
>
> There in fact are 3rd party modules that modify the dumpable flag, and
> this patch should fix the situation for them once again (for example
> vmware).
Nack, the just shouldn't do such things at all. I start to get really
sick of patches adding random exports everywhere.
next prev parent reply other threads:[~2007-10-14 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 11:04 [PATCH] remove GPL restriction from set_dumpable() Jiri Kosina
2007-10-14 15:36 ` Arjan van de Ven
2007-10-14 21:03 ` Christoph Hellwig [this message]
2007-10-14 21:14 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071014210341.GA30029@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox