From: Alasdair G Kergon <agk@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org,
Milan Broz <mbroz@redhat.com>, Guido Guenther <agx@sigxcpu.org>,
Kevin Corry <kevcorry@us.ibm.com>,
stable@kernel.org
Subject: Re: [2.6.24 PATCH 02/25] dm io:ctl use constant struct size
Date: Mon, 15 Oct 2007 02:26:21 +0100 [thread overview]
Message-ID: <20071015012621.GD10006@agk.fab.redhat.com> (raw)
In-Reply-To: <200710130016.29937.arnd@arndb.de>
On Sat, Oct 13, 2007 at 12:16:29AM +0200, Arnd Bergmann wrote:
> This change seems rather bogus, you're changing the ABI just to work
> around a bug in the compat_ioctl layer. Why not just do the compat
> code the right way, like the patch below?
The underlying ABI is not changing, I hope - the trailing padding in the
struct should not affect the processing of the data by dm, and I see no
reason to continue maintaining the fiction that the 32-bit and 64-bit
ioctls are in some way incompatible with each other when they aren't
AFAIK.
And yes, a follow-up patch can clean up our use of the compatibility
mechanism, going a little bit further than the patch you attached, I
hope.
Alasdair
--
agk@redhat.com
next prev parent reply other threads:[~2007-10-15 1:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 17:05 [2.6.24 PATCH 02/25] dm io:ctl use constant struct size Alasdair G Kergon
2007-10-12 22:16 ` Arnd Bergmann
2007-10-15 1:26 ` Alasdair G Kergon [this message]
2007-10-15 7:34 ` Arnd Bergmann
2007-11-13 22:22 ` [stable] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015012621.GD10006@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=agx@sigxcpu.org \
--cc=arnd@arndb.de \
--cc=dm-devel@redhat.com \
--cc=kevcorry@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox