From: Andrew Morton <akpm@linux-foundation.org>
To: Gilles Gigan <gilles.gigan@bluebottle.com>
Cc: gilles.gigan@bluebottle.com, linux-kernel@vger.kernel.org, wim@iguana.be
Subject: Re: [PATCH] watchdog: add Nano 7240 driver
Date: Mon, 15 Oct 2007 12:15:16 -0700 [thread overview]
Message-ID: <20071015121516.5067a462.akpm@linux-foundation.org> (raw)
In-Reply-To: <200710071249.l97CnAYC021425@mi1.bluebottle.com>
On Sun, 07 Oct 2007 22:49:00 +1000
Gilles Gigan <gilles.gigan@bluebottle.com> wrote:
> Andrey Panin wrote:
> >> +#ifdef CONFIG_WATCHDOG_NOWAYOUT
> >> +#define NOWAYOUT 1
> >> +#else
> >> +#define NOWAYOUT 0
> >> +#endif
> >> +static int nowayout = NOWAYOUT;
> >
> > You don't need this #ifdef crap. Just use WATCHDOG_NOWAYOUT instead.
>
> done
>
>
> >> + if ((_IOC_DIR(cmd) & _IOC_READ) &&
> >> + (!access_ok(VERIFY_WRITE, (void __user *)arg, _IOC_SIZE(cmd))))
> >> + return -EFAULT;
> >> + if ((_IOC_DIR(cmd) & _IOC_WRITE) &&
> >> + (!access_ok(VERIFY_READ, (void __user *)arg, _IOC_SIZE(cmd))))
> >> + return -EFAULT;
> >
> > Is this really needed ?
>
> removed
>
> Signed-off-by: Gilles Gigan <gilles.gigan@bluebottle.com>
> ---
>
> diff -uprN -X linux-2.6.23-rc9/Documentation/dontdiff
> linux-2.6.23-rc9/drivers/char/watchdog/Kconfig
> linux-2.6.23-rc9-dirty/drivers/char/watchdog/Kconfig
Could you please send a new version of this patch which has
a changelog, isn't space-stuffed and isn't wordwrapped?
Thanks.
next prev parent reply other threads:[~2007-10-15 19:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-06 15:39 [PATCH] watchdog: add Nano 7240 driver Gilles Gigan
2007-10-07 7:08 ` Andrey Panin
2007-10-07 12:49 ` Gilles Gigan
2007-10-15 19:15 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-10-24 2:11 Gilles Gigan
2007-10-24 2:29 ` Andrew Morton
2007-10-24 15:22 ` Wim Van Sebroeck
2007-10-24 16:27 ` Alan Cox
2007-10-31 6:31 ` Gilles Gigan
2007-10-24 15:16 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015121516.5067a462.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gilles.gigan@bluebottle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox