From: Andrew Morton <akpm@linux-foundation.org>
To: minyard@acm.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] IPMI: new NMI handling
Date: Mon, 15 Oct 2007 14:53:09 -0700 [thread overview]
Message-ID: <20071015145309.c762d36a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071012164057.GE22142@minyard.local>
On Fri, 12 Oct 2007 11:40:57 -0500
Corey Minyard <minyard@acm.org> wrote:
> -#ifdef CONFIG_X86_LOCAL_APIC
> -#include <asm/apic.h>
> +#ifdef CONFIG_X86
> +/* This is ugly, but I've determined that x86 is the only architecture
> + that can reasonably support the IPMI NMI watchdog timeout at this
> + time. If another architecture adds this capability somehow, it
> + will have to be a somewhat different mechanism and I have no idea
> + how it will work. So in the unlikely event that another
> + architecture supports this, we can figure out a good generic
> + mechanism for it at that time. */
> +#include <asm/kdebug.h>
> +#define HAVE_DIE_NMI
A preferred way of doing this would be to add a new CONFIG_IPMI_USE_IPMI in
arch/i386/Kconfig and arch/x86_64/Kconfig only, then use that in the ipmi
code.
prev parent reply other threads:[~2007-10-15 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 16:40 [PATCH 5/7] IPMI: new NMI handling Corey Minyard
2007-10-15 21:53 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015145309.c762d36a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox