From: Dave Jones <davej@redhat.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Mark Langsdorf <mark.langsdorf@amd.com>,
Andi Kleen <andi@firstfloor.org>,
cpufreq@lists.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][try 2] architectural pstate driver for powernow-k8
Date: Mon, 15 Oct 2007 11:40:31 -0400 [thread overview]
Message-ID: <20071015154031.GA30754@redhat.com> (raw)
In-Reply-To: <20071011075958.GK1130@shadowen.org>
On Thu, Oct 11, 2007 at 08:59:58AM +0100, Andy Whitcroft wrote:
> > /* get fid did for hardware pstate transition */
> > pstate = index & HW_PSTATE_MASK;
> > - if (pstate > MAX_HW_PSTATE)
> > + if (pstate > data->max_hw_pstate);
> > return 0;
>
> checkpatch picked up this dodgy if. I suspect that the ';' is wrong
> from the context.
Indeed. Mark/Andreas, want to send me a new patch against latest
Linus HEAD ? I didn't apply the old one yet, as it conflicted with
the changes already queued for merging.
Thanks,
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-10-15 15:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 19:46 [PATCH] architectural pstate driver for powernow-k8 Mark Langsdorf
2007-10-09 20:06 ` Andi Kleen
2007-10-09 20:43 ` [PATCH][try 2] " Mark Langsdorf
2007-10-09 23:41 ` Dave Jones
2007-10-10 16:35 ` Andreas Herrmann3
2007-10-10 17:06 ` Langsdorf, Mark
2007-10-11 7:59 ` Andy Whitcroft
2007-10-15 15:40 ` Dave Jones [this message]
2007-10-15 16:23 ` [PATCH][try 3] " Mark Langsdorf
2007-10-15 20:32 ` Dave Jones
2007-10-15 21:03 ` [PATCH][try 4] " Mark Langsdorf
2007-10-17 21:33 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015154031.GA30754@redhat.com \
--to=davej@redhat.com \
--cc=andi@firstfloor.org \
--cc=apw@shadowen.org \
--cc=cpufreq@lists.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox