Re: 2.6.23-mm1 pm_prepare() and _finish() w/ args vs. without

Joseph Fannin
2007-10-16T17:30:00Z

On Mon, Oct 15, 2007 at 10:55:06PM +0200, Rafael J. Wysocki wrote:
> On Sunday, 14 October 2007 22:20, Rafael J. Wysocki wrote:
> > On Sunday, 14 October 2007 21:47, Joseph Fannin wrote:
> > > On Sat, Oct 13, 2007 at 09:13:13PM +0200, Rafael J. Wysocki wrote:
> > >
> > > > Yes. Corrected patch follows.
> > >
> > > A bit more is needed due to the rename of lite5200_pm_init() to
> > > lite5200_suspend_init().
> >
> > Well, I didn't intend to change it. :-)
> >
> > > An amended patch follows that builds and boots on my powermac.
> >
> > Thanks.
> >
> > Can you please try the alternative one below?
> >
> > I just removed the renaming of lite5200_pm_init() from it.
>
> Well, from the lack of response I gather it works. :-)
>
> I'm going to send it in a separate thread with a changelog. Please object if
> it doesn't work.

This patch builds and boots on my powermac. Also, I checked, and
the remaning warnings from gcc in this general area are also present
in Linus's -git.

> Greetings,
> Rafael

Thanks!

--
Joseph Fannin
jfannin@gmail.com