Re: [PATCH 2.6.23] oProfile: op_model_athalon.c support for AMD Family10h (Barcelona) Performance Counters

["Robert Richter" <robert.richter@amd.com>]

On 15.10.07 13:00:27, Barry Kasindorf wrote:
> 
> oProfile Driver Module Patch for AMD Family10h Kernel 2.6.23
> This patch is for controlling the upper 32bits of the event ctrl msrs.
> This includes the upper 4 bits of the event select and the Guest Only 
> and Host Only bits
> This patch is necessary to make Event Based Profiling work reliably on a 
> Family10h processor
> 
> ---
>  op_model_athlon.c |   22 ++++++++++++++++------
>  1 file changed, 16 insertions(+), 6 deletions(-)
> ---
> 
> Signed-off-by: Barry Kasindorf <barry.kasindorf@amd.com>
> Signed-off-by: Robert Richter <robert.richter@amd.com>
> 
> diff -Naur linux-2.6.23.orig/arch/i386/oprofile/op_model_athlon.c 
> linux-2.6.23.pmc/arch/i386/oprofile/op_model_athlon.c
> --- linux-2.6.23.orig/arch/i386/oprofile/op_model_athlon.c	2007-10-09 
> 16:31:38.000000000 -0400
> +++ linux-2.6.23.pmc/arch/i386/oprofile/op_model_athlon.c	2007-10-15 
> 11:02:39.000000000 -0400

[]

> @@ -70,7 +74,8 @@
>  		if (unlikely(!CTRL_IS_RESERVED(msrs,i)))
>  			continue;
>  		CTRL_READ(low, high, msrs, i);
> -		CTRL_CLEAR(low);
> +		CTRL_CLEAR_LO(low);
> +		CTRL_CLEAR_HI(low);

Should be probably this:

CTRL_CLEAR_HI(high);

>  		CTRL_WRITE(low, high, msrs, i);
>  	}
> 

[]

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com