public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Whitcroft <apw@shadowen.org>
To: Erez Zadok <ezk@cs.sunysb.edu>
Cc: "Mike D. Day" <ncmike@us.ibm.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] checkpatch: Fix line number reporting
Date: Mon, 15 Oct 2007 19:21:18 +0100	[thread overview]
Message-ID: <20071015182118.GA4459@shadowen.org> (raw)
In-Reply-To: <200710131835.l9DIZCYp030867@agora.fsl.cs.sunysb.edu>

On Sat, Oct 13, 2007 at 02:35:12PM -0400, Erez Zadok wrote:
> In message <20071012193751.GA31579@shadowen.org>, Andy Whitcroft writes:
> > On Fri, Oct 12, 2007 at 03:26:54PM -0400, Mike D. Day wrote:
> > > Fix line number reporting when checking source files (as opposed to
> > > patches)
> > > 
> > > Signed-off-by: Mike D. Day <ncmike@us.ibm.com>
> > 
> > Sorry you've had to fix this about 4 times, mostly because of ongoing
> > changes, and slow replication getting in the way.  I've applied this
> > and you should find it in -next when replication hits.  md5sum is
> > below of the version with it in, so you can make sure you've got
> > the right one.
> > 
> > 54f053c50265e44a6041e3147dc66a69  checkpatch.pl
> > 
> > -apw
> 
> Andy, I've tested the --emacs feature in the above latest
> checkpatch.pl-next.  Below is a patch that completes the functionality of
> the --emacs option: it ensures that only the cc-style error messages are
> printed, no extra context lines or caret lines, no extra newlines, etc.
> Although this patch changes every call to a message-producing function, it
> is a trivial change, and I believe it's the cleanest way to handle the
> separation between the terse cc-style messages and the verbose default
> messages.  With this patch, I can finally test a single source file as
> follows:
> 
> $ ./scripts/checkpatch.pl -q -q --emacs --file path/name/to/file

Ok I don't understand why the rest of the lines are a problem?  At least
with emacs the extra context lines are just ignored right?  Are you
trying to use this as a summary?

-apw

  reply	other threads:[~2007-10-15 18:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12 19:26 [PATCH] checkpatch: Fix line number reporting Mike D. Day
2007-10-12 19:37 ` Andy Whitcroft
2007-10-13 18:35   ` Erez Zadok
2007-10-15 18:21     ` Andy Whitcroft [this message]
2007-10-16 17:59       ` Erez Zadok
2007-10-17 16:39         ` Andy Whitcroft
2007-10-18 11:13           ` latest checkpatch Ingo Molnar
2007-10-18 19:25             ` Andy Whitcroft
2007-10-18 19:39               ` Ingo Molnar
2007-10-18 20:02                 ` Avi Kivity
2007-10-18 20:51                   ` Ingo Molnar
2007-10-18 20:57                     ` Jeff Garzik
2007-10-18 22:25                       ` Randy Dunlap
2007-10-19  9:01                     ` Andy Whitcroft
2007-10-18 23:16                   ` Andi Kleen
2007-10-19  9:12                 ` Ilpo Järvinen
2007-10-18 19:43               ` Andy Whitcroft
2007-10-18 20:00                 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071015182118.GA4459@shadowen.org \
    --to=apw@shadowen.org \
    --cc=ezk@cs.sunysb.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=ncmike@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox