Re: latest checkpatch

Andy Whitcroft
2007-10-19T09:01:28Z

On Thu, Oct 18, 2007 at 10:51:47PM +0200, Ingo Molnar wrote:
>
> * Avi Kivity <avi@qumranet.com> wrote:
>
> > >> if (foo)
> > >> bar();
> > >> baz();
> > >> one();
> > >>
> > >
> > > detecting that would be awesome - it's often the sign of a real bug
> > > because the intent is often to have bar() and baz() in the conditional
> > > block.
> >
> > This is more useful operating on an entire file, so the script can see
> > all the context.
>
> there's "checkpatch --file" for complete files, so it can see the full
> context if the user passes it in.

Indeed so. checkpatch uses all the context it can when making a
decision. Often 3 lines carries enough history to figure this out.

-apw