Re: [patch] usb: fix ssb_ohci_probe() build bug

[Michael Buesch <mb@bu3sch.de>]

On Monday 15 October 2007 19:43:21 Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
> > find attached another config that reproduces the build failure above.
> > 
> > i think the reason is this:
> > 
> > CONFIG_SSB=m
> > CONFIG_USB_OHCI_HCD=y
> > CONFIG_USB_OHCI_HCD_SSB=y
> 
> the patch below fixes this for me.
> 
> 	Ingo
> 
> ----------------------->
> Subject: usb: fix ssb_ohci_probe() build bug
> From: Ingo Molnar <mingo@elte.hu>
> 
> fix ssb_ohci_probe() build bug:
> 
>  drivers/built-in.o: In function `ssb_ohci_probe':
>  ohci-hcd.c:(.text+0xbff39): undefined reference to `ssb_device_enable'
>  ohci-hcd.c:(.text+0xbff6f): undefined reference to `ssb_admatch_base'
>  ohci-hcd.c:(.text+0xbff8b): undefined reference to `ssb_admatch_size'
>  ohci-hcd.c:(.text+0xbffe5): undefined reference to `ssb_device_disable'
>  [...]
> 
> the reason was that this Kconfig combination was allowed:
> 
>  CONFIG_SSB=m
>  CONFIG_USB_OHCI_HCD=y
>  CONFIG_USB_OHCI_HCD_SSB=y
> 
> the fix is to require a modular USB_OHCI_HCD build when SSB is modular.
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>

Acked-by: Michael Buesch <mb@bu3sch.de>

Somebody of the USB folks apply this, please.

> ---
>  drivers/usb/host/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux/drivers/usb/host/Kconfig
> ===================================================================
> --- linux.orig/drivers/usb/host/Kconfig
> +++ linux/drivers/usb/host/Kconfig
> @@ -156,7 +156,7 @@ config USB_OHCI_HCD_PCI
>  
>  config USB_OHCI_HCD_SSB
>  	bool "OHCI support for Broadcom SSB OHCI core"
> -	depends on USB_OHCI_HCD && SSB && EXPERIMENTAL
> +	depends on USB_OHCI_HCD && (SSB = y || SSB = CONFIG_USB_OHCI_HCD) && EXPERIMENTAL
>  	default n
>  	---help---
>  	  Support for the Sonics Silicon Backplane (SSB) attached
> 
> 



-- 
Greetings Michael.