public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Alexey Dobriyan <adobriyan@sw.ru>,
	linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: Possible circular locking: ->mmap_sem vs jbd_handle
Date: Tue, 16 Oct 2007 02:08:26 -0700	[thread overview]
Message-ID: <20071016020826.6a0263cd.akpm@linux-foundation.org> (raw)
In-Reply-To: <1192525512.27435.90.camel@twins>

On Tue, 16 Oct 2007 11:05:12 +0200 Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

> On Tue, 2007-10-16 at 02:01 -0700, Andrew Morton wrote:
> > On Tue, 16 Oct 2007 12:54:29 +0400 Alexey Dobriyan <adobriyan@sw.ru> wrote:
> > 
> > > Got this during LTP's diotest1. Reproducable.
> > > 
> > > =======================================================
> > > [ INFO: possible circular locking dependency detected ]
> > > 2.6.23-65a6ec0d72a07f16719e9b7a96e1c4bae044b591 #2
> > > -------------------------------------------------------
> > > diotest1/13563 is trying to acquire lock:
> > >  (&mm->mmap_sem){----}, at: [<c107a7b7>] dio_get_page+0x4b/0x16b
> > > 
> > > but task is already holding lock:
> > >  (jbd_handle){--..}, at: [<c1099b05>] journal_start+0xf3/0x120
> > > 
> > > which lock already depends on the new lock.
> > 
> > Someone taught lockdep about journal_start?  That's gonna hurt.
> 
> It was you who suggested doing so,...

yeah, but I didn't think anyone would go and do it!

> Are these valid reports, or is the annotation wrong?

It's valid.  There will be others..


      reply	other threads:[~2007-10-16  9:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-16  8:54 Possible circular locking: ->mmap_sem vs jbd_handle Alexey Dobriyan
2007-10-16  9:01 ` Andrew Morton
2007-10-16  9:05   ` Peter Zijlstra
2007-10-16  9:08     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071016020826.6a0263cd.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=adobriyan@sw.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox