From: Ingo Molnar <mingo@elte.hu>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
shemminger@linux-foundation.org
Subject: Re: [patch] forcedeth: fix the NAPI poll function
Date: Tue, 16 Oct 2007 07:42:36 +0200 [thread overview]
Message-ID: <20071016054236.GA27906@elte.hu> (raw)
In-Reply-To: <4713EC59.4010106@pobox.com>
* Jeff Garzik <jgarzik@pobox.com> wrote:
> Two comments:
>
> 1) we have a vague definition of "RX work processed." Due to error
> conditions and goto's in that function, rx_processed_cnt may or may
> not equal the number of packets actually processed.
>
> 2) man I dislike these inline C statement combinations (ranting at
> original code style, not you). I would much rather waste a few extra
> lines of source code and make the conditions obvious:
>
> while (... && (rx_processed_cnt < limit)) {
> rx_processed_cnt++;
>
> ...
> }
>
> or even
>
> while (1) {
> ...
> if (rx_processed_cnt == limit)
> break;
> rx_processed_cnt++;
> }
>
> The compiler certainly doesn't care, and IMO it prevents bugs.
agreed. Do you have an uptodate patch/git-URI for the forcedeth rewrite
you did? I can throw it into the testbed.
Ingo
next prev parent reply other threads:[~2007-10-16 5:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 11:24 WARNING: at net/core/dev.c:2161 net_rx_action() Ingo Molnar
2007-10-15 11:27 ` Ingo Molnar
2007-10-15 16:18 ` Ingo Molnar
2007-10-15 19:57 ` David Miller
2007-10-15 22:03 ` Ingo Molnar
2007-10-15 22:07 ` Ingo Molnar
2007-10-15 22:21 ` David Miller
2007-10-15 22:30 ` [patch] forcedeth: fix the NAPI poll function Ingo Molnar
2007-10-15 22:39 ` David Miller
2007-10-15 22:40 ` Jeff Garzik
2007-10-15 22:41 ` Jeff Garzik
2007-10-16 5:42 ` Ingo Molnar [this message]
2007-10-16 5:47 ` Jeff Garzik
2007-10-16 6:40 ` Ingo Molnar
2007-10-16 7:17 ` Jeff Garzik
2007-10-16 7:49 ` Ingo Molnar
2007-10-16 16:52 ` Jeff Garzik
2007-10-16 21:20 ` Jeff Garzik
2007-10-17 7:25 ` Ingo Molnar
2007-10-17 10:18 ` [patch] forcedeth: fix the NAPI poll function, take #2 Ingo Molnar
2007-10-18 0:21 ` Jeff Garzik
2007-10-15 22:18 ` WARNING: at net/core/dev.c:2161 net_rx_action() David Miller
2007-10-15 22:20 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071016054236.GA27906@elte.hu \
--to=mingo@elte.hu \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox