public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jeff Garzik <jeff@garzik.org>
Cc: David Miller <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	shemminger@linux-foundation.org
Subject: Re: [patch] forcedeth: fix the NAPI poll function
Date: Tue, 16 Oct 2007 09:49:43 +0200	[thread overview]
Message-ID: <20071016074943.GA24481@elte.hu> (raw)
In-Reply-To: <47146593.2060909@garzik.org>


* Jeff Garzik <jeff@garzik.org> wrote:

> >FYI, looks good so far, ontop of Linus' latest -git tree.
> >
> >btw., one thing i always found weird about forcedeth is that it 
> >generates an extra ~100 irqs per second even when there's no network 
> >traffic:
> >
> > 11:      89752    XT-PIC-XT        eth0
> > 11:      89854    XT-PIC-XT        eth0
> > 11:      89955    XT-PIC-XT        eth0
> > 11:      90056    XT-PIC-XT        eth0
> > 11:      90157    XT-PIC-XT        eth0
> >
> >(irq count snapshot every second). Just in case it's easy to fix ...
> 
> 
> May I presume that behavior occurs in both mainline and my fe-lock 
> branch?

correct.

> That is likely the NIC's timer irq, which is programmed to kick the 
> irq handler every so often.  DEV_NEED_TIMERIRQ is a starting point, as 
> well as "Known bugs" at the top of forcedeth.c, if you're curious.
> 
> I'm _betting_ that some of that can be eliminated, but we'll see...

ok. Was just a FYI - you were looking for feedback :-)

	Ingo

  reply	other threads:[~2007-10-16  7:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-15 11:24 WARNING: at net/core/dev.c:2161 net_rx_action() Ingo Molnar
2007-10-15 11:27 ` Ingo Molnar
2007-10-15 16:18   ` Ingo Molnar
2007-10-15 19:57 ` David Miller
2007-10-15 22:03   ` Ingo Molnar
2007-10-15 22:07     ` Ingo Molnar
2007-10-15 22:21       ` David Miller
2007-10-15 22:30       ` [patch] forcedeth: fix the NAPI poll function Ingo Molnar
2007-10-15 22:39         ` David Miller
2007-10-15 22:40         ` Jeff Garzik
2007-10-15 22:41           ` Jeff Garzik
2007-10-16  5:42           ` Ingo Molnar
2007-10-16  5:47             ` Jeff Garzik
2007-10-16  6:40               ` Ingo Molnar
2007-10-16  7:17                 ` Jeff Garzik
2007-10-16  7:49                   ` Ingo Molnar [this message]
2007-10-16 16:52                     ` Jeff Garzik
2007-10-16 21:20         ` Jeff Garzik
2007-10-17  7:25           ` Ingo Molnar
2007-10-17 10:18             ` [patch] forcedeth: fix the NAPI poll function, take #2 Ingo Molnar
2007-10-18  0:21               ` Jeff Garzik
2007-10-15 22:18     ` WARNING: at net/core/dev.c:2161 net_rx_action() David Miller
2007-10-15 22:20     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071016074943.GA24481@elte.hu \
    --to=mingo@elte.hu \
    --cc=davem@davemloft.net \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox