From: Ingo Molnar <mingo@elte.hu>
To: Milton Miller <miltonm@bga.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched domain sysctl: free kstrdup allocations
Date: Tue, 16 Oct 2007 10:44:27 +0200 [thread overview]
Message-ID: <20071016084427.GA13571@elte.hu> (raw)
In-Reply-To: <mm-sched-2b@bga.com>
* Milton Miller <miltonm@bga.com> wrote:
> The procnames for the cpu and domain were allocated via kstrdup and so
> should also be freed. The names for the files are static, but we can
> differentiate them by the presence of the proc_handler. If a kstrdup
> (of < 32 characters) fails the sysctl code will not see the procname
> or remaining table entries, but any child tables and names will be
> reclaimed upon free.
thanks, applied.
Ingo
prev parent reply other threads:[~2007-10-16 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 9:34 [PATCH] sched domain debug sysctl fixes Milton Miller
2007-10-12 9:35 ` [PATCH] sched.c: use kcalloc Milton Miller
2007-10-12 9:35 ` [PATCH] sched domain sysctl: register online cpus Milton Miller
2007-10-12 9:35 ` [PATCH] sched domain sysctl: free and rebuild when changing domains Milton Miller
2007-10-12 9:35 ` [PATCH] sched domain sysctl: don't bug on alloc failure Milton Miller
2007-10-12 9:35 ` [PATCH] sched domain sysctl: sysctl tables can have no holes Milton Miller
2007-10-12 9:54 ` [PATCH] sched domain debug sysctl fixes Milton Miller
2007-10-15 7:47 ` Ingo Molnar
2007-10-15 23:40 ` [PATCH] sched domain sysctl: free kstrdup allocations Milton Miller
2007-10-16 8:44 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071016084427.GA13571@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox