Re: [PATCH] Map volume and brightness events on thinkpads

[Henrique de Moraes Holschuh <hmh@hmh.eng.br>]

On Tue, 16 Oct 2007, Jesse Barnes wrote:
> On Tuesday, October 16, 2007 1:36 am Henrique de Moraes Holschuh wrote:
> > You want ACPI video to just pass the messages to userspace when X.org
> > is driving the backlight?  Fine with me.  That *still* doesn't make
> > it right to get these messages as hot key presses over the input
> > layer through the thinkpad-acpi driver.  So the NAK stands.  Any
> > changes should be done to the ACPI video driver in this case.
> 
> So is this really the direction that input is going?  Last time I talked 
> with Dmitry, he seemed ok with adding input events for ACPI and other 
> firmware hotkeys...

Last time the issue was brought up (and I do believe it was because of
thinkpad-acpi :-) ), he made it clear that any events you are to act upon
are fine in input, but events that are just notifications (i.e. the firmware
already did the action) are not.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh