Re: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.

[Willy Tarreau <w@1wt.eu>]

On Tue, Oct 16, 2007 at 04:54:49PM +0300, Vitaliy Ivanov wrote:
> Willy,
> 
> On Mon, 2007-10-15 at 01:39, Willy Tarreau wrote:
> 
> > That's what I've seen. I can propose you something (unless someone
> > else raises his hand saying "no") : you update your patch with a
> > short description of what the hardware module is supposed to be used
> > for, and you accept to step up as the maintainer for this backport,
> > which will imply that you put your name and mail in the MAINTAINERS
> > file. That way, if you're the only user, nobody will be annoyed, and
> > if there are other users and some of them have problems, I don't waste
> > my time on something I don't know at all. If you agree with this deal
> > (which I think is fair), then I'm willing to merge your patch into
> > 2.4.36-pre.
> 
> It's completely fair. I spent some time on lkml and I liked it.
> I've a device and I can check/correct any issue we'll have with it(hope there won't be any;)).
> So it's OK for me to be a maintainer for this driver.
> 
> Here is final patch with all issues corrected.
> 
> Again, comments are welcomed.

OK, I have no objection, but please apply the fixes the le16 problem as
suggested by Pete and Greg first. Also, you will probably receive more
comments, and/or criticisms from further reviews. This is normal and
expected. You just have to fix your code so that it can be merged.

> adutux is a simple Linux device driver for ADU boards from Ontrak Control Systems. 
> The adutux driver exposes standard open/close/read/write API's to the user application.

If this is going to be the commit message, please reduce lines to less
than 70 chars, and also enumerate the supportd devices and the one you
performed the tests with. It helps a lot when users encounter problems.

Also, if you did not (I forgot to check), please ensure that the adutux
maintainer in 2.6 is CC'd.

Last but not least, please remove the "KERNELS/" path component from
your next diff.

Thanks,
Willy