From: Andrew Morton <akpm@linux-foundation.org>
To: akepner@sgi.com
Cc: Tony Luck <tony.luck@intel.com>,
Grant Grundler <grundler@parisc-linux.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Jes Sorensen <jes@sgi.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Roland Dreier <rdreier@cisco.com>,
James Bottomley <James.Bottomley@steeleye.com>,
David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dma: redefine dma_flags_set/get_*() for sn-ia64
Date: Tue, 16 Oct 2007 20:29:04 -0700 [thread overview]
Message-ID: <20071016202904.8e9d505b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071017014316.GK5601@sgi.com>
On Tue, 16 Oct 2007 18:43:16 -0700 akepner@sgi.com wrote:
> @@ -153,7 +153,7 @@ EXPORT_SYMBOL(sn_dma_free_coherent);
> * @dev: device to map for
> * @cpu_addr: kernel virtual address of the region to map
> * @size: size of the region
> - * @direction: DMA direction
> + * @flags: DMA direction, and arch-specific attributes
> *
> * Map the region pointed to by @cpu_addr for DMA and return the
> * DMA address.
> @@ -167,17 +167,23 @@ EXPORT_SYMBOL(sn_dma_free_coherent);
> * figure out how to save dmamap handle so can use two step.
> */
> dma_addr_t sn_dma_map_single(struct device *dev, void *cpu_addr, size_t size,
> - int direction)
> + int flags)
> {
> dma_addr_t dma_addr;
> unsigned long phys_addr;
> struct pci_dev *pdev = to_pci_dev(dev);
> struct sn_pcibus_provider *provider = SN_PCIDEV_BUSPROVIDER(pdev);
> + int dmabarrier = dma_flags_get_attr(flags) & DMA_BARRIER_ATTR;
So we take an `enum data_direction' and then wedge it into a word alongside
some extra flags?
Can we do something nicer than that?
next prev parent reply other threads:[~2007-10-17 3:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 1:43 [PATCH 2/3] dma: redefine dma_flags_set/get_*() for sn-ia64 akepner
2007-10-17 3:29 ` Andrew Morton [this message]
2007-10-17 3:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071016202904.8e9d505b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@steeleye.com \
--cc=akepner@sgi.com \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=jes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox