From: Matthew Wilcox <matthew@wil.cx>
To: Luming Yu <luming.yu@gmail.com>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC patch] fallback to "no irq" hack for case of no pnp_irq allocated for 8250_pnp
Date: Tue, 16 Oct 2007 22:40:03 -0600 [thread overview]
Message-ID: <20071017044003.GC16728@parisc-linux.org> (raw)
In-Reply-To: <3877989d0710161950n3d255330lf55e190dde628277@mail.gmail.com>
On Wed, Oct 17, 2007 at 10:50:53AM +0800, Luming Yu wrote:
> There is a "ttyS1 irq is -1" problem observed on tiger4 which cause
> the serial port broken.
> It is because that there is __no__ ACPI IRQ resource assigned for the
> serial port. So the value of the IRQ for the port is never changed
> since it got initialized to -1. The attached patch falls back to the
> "no irq" hack for this case. It works for me. Please review and test.
Seems reasonable to me. Although arguably pnp_irq is broken, since
Linus has decreed that 0 means no irq on Linux.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-10-17 4:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 2:50 [RFC patch] fallback to "no irq" hack for case of no pnp_irq allocated for 8250_pnp Luming Yu
2007-10-17 4:40 ` Matthew Wilcox [this message]
2007-10-17 10:49 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017044003.GC16728@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox