From: Andrew Morton <akpm@linux-foundation.org>
To: akepner@sgi.com
Cc: tony.luck@intel.com, grundler@parisc-linux.org,
jbarnes@virtuousgeek.org, jes@sgi.com, randy.dunlap@oracle.com,
rdreier@cisco.com, James.Bottomley@steeleye.com,
davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dma: add dma_flags_set/get_*() interfaces
Date: Wed, 17 Oct 2007 13:10:54 -0700 [thread overview]
Message-ID: <20071017131054.d3d88c62.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071017160327.GP5601@sgi.com>
On Wed, 17 Oct 2007 09:03:27 -0700
akepner@sgi.com wrote:
> >
> > What would be the cost of doing this cleanly and either redefining
> > dma_data_direction to be a field-of-bits or just leave dma_data_direction
> > alone (it is quite unrelated to this work, isn't it?) and adding new
> > fields/arguments to manage this new functionality?
>
> It'd be significantly more work to do change or add arguments
> to the dma_map_* functions. But if that's what I need to do to
> get this accepted, I'll back up and have another go at it.
I don't have any particularly strong opinions on which would be the best
way to clean this up. Hopefully someone who is more involved with the DMA
mapping interfaces can help out.
It wouldn't be efficient for you to implement something new, only to have
it criticized again. I'd suggest that you come up with a concrete
design, describe to us what you propose to do and let's take it from there.
prev parent reply other threads:[~2007-10-17 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 1:41 [PATCH 1/3] dma: add dma_flags_set/get_*() interfaces akepner
2007-10-17 3:27 ` Andrew Morton
2007-10-17 16:03 ` akepner
2007-10-17 20:10 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017131054.d3d88c62.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@steeleye.com \
--cc=akepner@sgi.com \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=jes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox