From: Ingo Molnar <mingo@elte.hu>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
torvalds@linux-foundation.org,
Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@shadowen.org>,
Dmitry Adamushko <dmitry.adamushko@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Mike Galbraith <efault@gmx.de>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>
Subject: Re: [BUG] 2.6.23-git8 kernel oops at __rb_rotate_left+0x7/0x70
Date: Wed, 17 Oct 2007 16:21:40 +0200 [thread overview]
Message-ID: <20071017142140.GA8634@elte.hu> (raw)
In-Reply-To: <47144B4F.3050108@linux.vnet.ibm.com>
* Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
> While running kernbench with the 2.6.23-git8 following oops is
> produced
Dmitry found something that might explain the crash: could you check
whether the patch below fixes it?
Ingo
---------------------->
Subject: sched: fix new task startup crash
From: Ingo Molnar <mingo@elte.hu>
this should fix the put_prev_task crashes that were reported,
Dmitry Adamushko noticed that it's not valid to call into
task_new_fair() if this_cpu != task_cpu(p).
Reported-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Reported-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/sched.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux/kernel/sched.c
===================================================================
--- linux.orig/kernel/sched.c
+++ linux/kernel/sched.c
@@ -1712,7 +1712,8 @@ void fastcall wake_up_new_task(struct ta
p->prio = effective_prio(p);
- if (!p->sched_class->task_new || !current->se.on_rq || !rq->cfs.curr) {
+ if (!p->sched_class->task_new || smp_processor_id() != task_cpu(p) ||
+ !current->se.on_rq || !rq->cfs.curr) {
activate_task(rq, p, 0);
} else {
/*
next prev parent reply other threads:[~2007-10-17 14:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 5:25 [BUG] 2.6.23-git8 kernel oops at __rb_rotate_left+0x7/0x70 Kamalesh Babulal
2007-10-16 9:10 ` Ingo Molnar
2007-10-16 9:46 ` Ingo Molnar
2007-10-16 18:00 ` Andy Whitcroft
2007-10-16 18:42 ` Srivatsa Vaddagiri
2007-10-17 9:07 ` Andy Whitcroft
2007-10-16 10:03 ` Andy Whitcroft
2007-10-17 14:21 ` Ingo Molnar [this message]
2007-10-17 14:43 ` Andy Whitcroft
2007-10-17 15:00 ` Srivatsa Vaddagiri
2007-10-17 14:52 ` Ingo Molnar
2007-10-17 15:29 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017142140.GA8634@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=dmitry.adamushko@gmail.com \
--cc=efault@gmx.de \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox