Re: [PATCH 1/3] dma: add dma_flags_set/get_*() interfaces

Andrew Morton
2007-10-17T03:28:53Z

On Tue, 16 Oct 2007 18:41:28 -0700 akepner@sgi.com wrote:

> +#define DMA_BARRIER_ATTR 0x1
> +#ifndef ARCH_USES_DMA_ATTRS
> +static inline int dma_flags_set_attr(u32 attr, enum dma_data_direction dir)
> +{
> + return dir;
> +}

This function takes an `enum dma_data_direction' as its second arg, but your
ia64 implementation takes an 'int'.

> +static inline int dma_flags_get_dir(int flags)
> +{
> + return flags;
> +}
> +
> +static inline int dma_flags_get_attr(int flags)
> +{
> + return 0;
> +}