Re: [PATCH 1/3] dma: add dma_flags_set/get_*() interfaces

Andrew Morton
2007-10-17T20:12:32Z

On Wed, 17 Oct 2007 09:03:27 -0700
akepner@sgi.com wrote:

> >
> > What would be the cost of doing this cleanly and either redefining
> > dma_data_direction to be a field-of-bits or just leave dma_data_direction
> > alone (it is quite unrelated to this work, isn't it?) and adding new
> > fields/arguments to manage this new functionality?
>
> It'd be significantly more work to do change or add arguments
> to the dma_map_* functions. But if that's what I need to do to
> get this accepted, I'll back up and have another go at it.

I don't have any particularly strong opinions on which would be the best
way to clean this up. Hopefully someone who is more involved with the DMA
mapping interfaces can help out.

It wouldn't be efficient for you to implement something new, only to have
it criticized again. I'd suggest that you come up with a concrete
design, describe to us what you propose to do and let's take it from there.