public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Antonino Daplas <adaplas@gmail.com>
Subject: Re: reduce frequency of cursor blinking
Date: Wed, 17 Oct 2007 15:38:39 -0400	[thread overview]
Message-ID: <20071017193839.GD9748@redhat.com> (raw)
In-Reply-To: <20071016113037.2fa3cd6f@laptopd505.fenrus.org>

On Tue, Oct 16, 2007 at 11:30:37AM -0700, Arjan van de Ven wrote:
 > On Tue, 16 Oct 2007 14:19:11 -0400
 > Dave Jones <davej@redhat.com> wrote:
 > 
 > > Depending on CONFIG_HZ, we blink the cursor at 20,50,60 or 200Hz.
 > 
 > eh no, that's 5 times per second ...

Indeed. Still seems excessive though.
How about twice per second ?

Signed-off-by: Dave Jones <davej@redhat.com>

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index 73813c6..7d9bae5 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -433,7 +433,7 @@ static void cursor_timer_handler(unsigned long dev_addr)
 	struct fbcon_ops *ops = info->fbcon_par;
 
 	schedule_work(&info->queue);
-	mod_timer(&ops->cursor_timer, jiffies + HZ/5);
+	mod_timer(&ops->cursor_timer, jiffies + HZ/2);
 }
 
 static void fbcon_add_cursor_timer(struct fb_info *info)
-- 
http://www.codemonkey.org.uk

      reply	other threads:[~2007-10-17 19:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-16 18:19 reduce frequency of cursor blinking Dave Jones
2007-10-16 18:30 ` Arjan van de Ven
2007-10-17 19:38   ` Dave Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071017193839.GD9748@redhat.com \
    --to=davej@redhat.com \
    --cc=adaplas@gmail.com \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox