* reduce frequency of cursor blinking
@ 2007-10-16 18:19 Dave Jones
2007-10-16 18:30 ` Arjan van de Ven
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2007-10-16 18:19 UTC (permalink / raw)
To: Linux Kernel; +Cc: Antonino Daplas
Depending on CONFIG_HZ, we blink the cursor at 20,50,60 or 200Hz.
Even if it only blinks once per 1000Hz, there's no visible difference.
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index 73813c6..7d9bae5 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -433,7 +433,7 @@ static void cursor_timer_handler(unsigned long dev_addr)
struct fbcon_ops *ops = info->fbcon_par;
schedule_work(&info->queue);
- mod_timer(&ops->cursor_timer, jiffies + HZ/5);
+ mod_timer(&ops->cursor_timer, jiffies + HZ);
}
static void fbcon_add_cursor_timer(struct fb_info *info)
--
http://www.codemonkey.org.uk
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: reduce frequency of cursor blinking
2007-10-16 18:19 reduce frequency of cursor blinking Dave Jones
@ 2007-10-16 18:30 ` Arjan van de Ven
2007-10-17 19:38 ` Dave Jones
0 siblings, 1 reply; 3+ messages in thread
From: Arjan van de Ven @ 2007-10-16 18:30 UTC (permalink / raw)
To: Dave Jones; +Cc: Linux Kernel, Antonino Daplas
On Tue, 16 Oct 2007 14:19:11 -0400
Dave Jones <davej@redhat.com> wrote:
> Depending on CONFIG_HZ, we blink the cursor at 20,50,60 or 200Hz.
eh no, that's 5 times per second ...
> - mod_timer(&ops->cursor_timer, jiffies + HZ/5);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: reduce frequency of cursor blinking
2007-10-16 18:30 ` Arjan van de Ven
@ 2007-10-17 19:38 ` Dave Jones
0 siblings, 0 replies; 3+ messages in thread
From: Dave Jones @ 2007-10-17 19:38 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: Linux Kernel, Antonino Daplas
On Tue, Oct 16, 2007 at 11:30:37AM -0700, Arjan van de Ven wrote:
> On Tue, 16 Oct 2007 14:19:11 -0400
> Dave Jones <davej@redhat.com> wrote:
>
> > Depending on CONFIG_HZ, we blink the cursor at 20,50,60 or 200Hz.
>
> eh no, that's 5 times per second ...
Indeed. Still seems excessive though.
How about twice per second ?
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index 73813c6..7d9bae5 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -433,7 +433,7 @@ static void cursor_timer_handler(unsigned long dev_addr)
struct fbcon_ops *ops = info->fbcon_par;
schedule_work(&info->queue);
- mod_timer(&ops->cursor_timer, jiffies + HZ/5);
+ mod_timer(&ops->cursor_timer, jiffies + HZ/2);
}
static void fbcon_add_cursor_timer(struct fb_info *info)
--
http://www.codemonkey.org.uk
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-17 19:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-16 18:19 reduce frequency of cursor blinking Dave Jones
2007-10-16 18:30 ` Arjan van de Ven
2007-10-17 19:38 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox