From: Adrian Bunk <bunk@kernel.org>
To: Riku Voipio <riku.voipio@iki.fi>,
"Mark M. Hoffman" <mhoffman@lightlink.com>
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: hwmon/f75375s.c: buggy if()
Date: Wed, 17 Oct 2007 21:54:39 +0200 [thread overview]
Message-ID: <20071017195439.GD3778@stusta.de> (raw)
drivers/hwmon/f75375s.c contains the following code:
<-- snip -->
...
static ssize_t set_pwm_mode(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
...
if (val != 0 || val != 1 || data->kind == f75373)
return -EINVAL;
...
<-- snip -->
I'm not sure what exactly was intended, but it was for sure not intended
to always return -EINVAL...
Spotted by the Coverity checker.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next reply other threads:[~2007-10-17 19:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 19:54 Adrian Bunk [this message]
2007-10-17 20:45 ` hwmon/f75375s.c: buggy if() Riku Voipio
2007-10-18 13:37 ` Mark M. Hoffman
2007-10-19 12:37 ` [lm-sensors] " Jean Delvare
2007-10-24 11:50 ` Riku Voipio
2007-10-25 2:25 ` Mark M. Hoffman
2007-10-25 11:48 ` Riku Voipio
2007-10-26 8:36 ` Jean Delvare
2007-10-26 11:14 ` Riku Voipio
2007-10-26 21:15 ` Jean Delvare
2007-10-28 17:33 ` Mark M. Hoffman
2007-10-25 11:09 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017195439.GD3778@stusta.de \
--to=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox