From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] serial: do not call ->pm() on initialization for console port
Date: Thu, 18 Oct 2007 17:18:27 +0100 [thread overview]
Message-ID: <20071018161827.GB16244@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20071019.011355.39154656.anemo@mba.ocn.ne.jp>
On Fri, Oct 19, 2007 at 01:13:55AM +0900, Atsushi Nemoto wrote:
> This commit in current git tree broke serial console for serial_txx9 driver.
>
> > commit 97d97224ff361e08777fb33e0fd193ca877dac28
> > Author: Russell King <rmk@dyn-67.arm.linux.org.uk>
> > Date: Sat Sep 1 21:25:09 2007 +0100
> >
> > [SERIAL] Fix console initialisation ordering
>
> The serial_txx9 driver initialize its port entirely on its ->pm()
> method if new state was 0. With the commit, serial_core calls ->pm()
> even if the port was used for console.
This'll break some of the ARM drivers, and although I investigated
this a month or so ago, I've completely forgotten the details.
> Attached patch fixes this problem. Is this a right way?
> If not, I will fix the serial_txx9 driver to skip the initialization in
> ->pm() if oldstate was -1.
I'll have to investigate further to refresh myself with what's going
on here, but your patch looks wrong.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-10-18 16:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 16:13 [PATCH] serial: do not call ->pm() on initialization for console port Atsushi Nemoto
2007-10-18 16:18 ` Russell King [this message]
2007-10-18 16:42 ` Atsushi Nemoto
2007-10-25 16:05 ` Atsushi Nemoto
2007-10-25 20:40 ` Andrew Morton
2007-10-25 21:36 ` Russell King
2007-10-26 3:12 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071018161827.GB16244@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox