From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Bernhard Walle <bwalle@suse.de>,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
ak@suse.de, vgoyal@in.ibm.com
Subject: Re: [patch 1/3] Add BSS to resource tree
Date: Thu, 18 Oct 2007 23:48:37 +0200 [thread overview]
Message-ID: <20071018214836.GA3459@bingen.suse.de> (raw)
In-Reply-To: <20071018142642.5b3f6ba4.akpm@linux-foundation.org>
> > +extern char _text[], _end[], _etext[], _edata[], _bss[];
>
> These should be in a header file.
Normally the "no externs in .c" rule doesn't apply to assembler or linker
script defined labels. That's because the point of the header file is to
type check them, but there is nothing to type check here.
-Andi
next prev parent reply other threads:[~2007-10-18 21:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 11:15 [patch 0/3] Protect crashkernel against BSS overlap Bernhard Walle
2007-10-18 11:15 ` [patch 1/3] Add BSS to resource tree Bernhard Walle
2007-10-18 21:26 ` Andrew Morton
2007-10-18 21:48 ` Andi Kleen [this message]
2007-10-18 21:58 ` Sam Ravnborg
2007-10-18 22:00 ` Andi Kleen
2007-10-18 22:18 ` Sam Ravnborg
2007-10-18 22:20 ` Andi Kleen
2007-10-18 22:37 ` Andrew Morton
2007-10-18 22:45 ` Andi Kleen
2007-10-19 0:27 ` Jeremy Fitzhardinge
2007-10-19 12:52 ` Bernhard Walle
2007-10-19 14:48 ` Bernhard Walle
2007-10-18 11:15 ` [patch 2/3] Introduce BOOTMEM_EXCLUSIVE Bernhard Walle
2007-10-18 11:15 ` [patch 3/3] Use BOOTMEM_EXCLUSIVE on x86 Bernhard Walle
-- strict thread matches above, loose matches on Subject: below --
2007-10-16 16:28 [patch 0/3] Protect crashkernel against BSS overlap Bernhard Walle
2007-10-16 16:28 ` [patch 1/3] Add BSS to resource tree Bernhard Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071018214836.GA3459@bingen.suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bwalle@suse.de \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox