public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Mike Galbraith <efault@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [bisected][mismerge?] Re: [microcode] 2.6.23.git pulled this morning oopses loading P4 microcode
Date: Thu, 18 Oct 2007 23:33:33 +0100	[thread overview]
Message-ID: <20071018223333.GD4153@implementation> (raw)
In-Reply-To: <1192730198.7182.18.camel@Homer.simpson.net>

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi,

Mike Galbraith, le Thu 18 Oct 2007 19:56:38 +0200, a écrit :
> The winner of a very long git bisect session:
> 
>     unicode diacritics support

Uh, I fail to see how that could have an impact, I've again checked the
boundaries, it looks fine, please people have a look.

Could you try something odd?  On your tree that has the change reverted,
please try the attached patch, which makes the array the same size at it
would be with the change, possibly triggering bugs in completely other
parts of the kernel.

Samuel

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 394 bytes --]

--- defkeymap.c_shipped.old	2007-10-18 22:44:59.000000000 +0000
+++ defkeymap.c_shipped	2007-10-18 22:44:43.000000000 +0000
@@ -222,7 +222,7 @@
 	NULL,
 };
 
-struct kbdiacr accent_table[MAX_DIACR] = {
+struct kbdiacr accent_table[(MAX_DIACR*3*4-MAX_DIACR*3)/3] = {
 	{'`', 'A', '\300'},	{'`', 'a', '\340'},
 	{'\'', 'A', '\301'},	{'\'', 'a', '\341'},
 	{'^', 'A', '\302'},	{'^', 'a', '\342'},

  reply	other threads:[~2007-10-18 22:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-18  4:25 [microcode] 2.6.23.git pulled this morning oopses loading P4 microcode Mike Galbraith
2007-10-18 17:56 ` [bisected][mismerge?] " Mike Galbraith
2007-10-18 22:33   ` Samuel Thibault [this message]
2007-10-19  2:48     ` Mike Galbraith
2007-10-19  8:55       ` Samuel Thibault
2007-10-19 10:20         ` Mike Galbraith
2007-10-19 10:18       ` Mike Galbraith
2007-10-19 15:34         ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071018223333.GD4153@implementation \
    --to=samuel.thibault@ens-lyon.org \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox