From: Pete Zaitcev <zaitcev@redhat.com>
To: "Vitaliy Ivanov" <vitalivanov@gmail.com>
Cc: w@1wt.eu, gregkh@suse.de, linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, zaitcev@redhat.com
Subject: Re: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.
Date: Fri, 19 Oct 2007 09:53:13 -0700 [thread overview]
Message-ID: <20071019095313.76990765.zaitcev@redhat.com> (raw)
In-Reply-To: <35fbaa3e0710190826uae4e7b7u7d8f3139e1697030@mail.gmail.com>
On Fri, 19 Oct 2007 18:26:35 +0300, "Vitaliy Ivanov" <vitalivanov@gmail.com> wrote:
> Didn't here anything on this? What is our final decision here?
It's gotten worse, not better. Apparently, you aren't getting the
concept of protecting the open count with a static lock and my
explanations are just not vivid enough or something. So I decided
to fix it myself. Maybe then the patch in C will explain it better
than English. But I didn't have time to do it.
Also, there's an outright bug in the latest version. Your purge
of the wrong lock was incomplete and so there was an unbalanced up().
But this is moot.
So, the version before the latest is borderline acceptable. If Willy
wants to take it, it's fine. I'll fix it up later together with 2.6.
-- Pete
next prev parent reply other threads:[~2007-10-19 16:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 17:37 [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4 Vitaliy Ivanov
2007-10-14 18:25 ` Willy Tarreau
2007-10-14 20:45 ` Vitaliy Ivanov
2007-10-14 22:39 ` Willy Tarreau
2007-10-16 13:54 ` Vitaliy Ivanov
2007-10-16 15:41 ` Willy Tarreau
2007-10-16 17:56 ` Pete Zaitcev
2007-10-16 18:22 ` Vitaliy Ivanov
2007-10-16 18:24 ` Willy Tarreau
2007-10-16 18:24 ` Vitaliy Ivanov
2007-10-17 18:12 ` Vitaliy Ivanov
2007-10-19 15:26 ` Vitaliy Ivanov
2007-10-19 16:53 ` Pete Zaitcev [this message]
2007-10-19 17:40 ` Vitaliy Ivanov
2007-10-23 3:45 ` Pete Zaitcev
2007-11-04 14:05 ` Willy Tarreau
2007-11-05 9:32 ` Vitaliy Ivanov
2007-11-05 9:36 ` Willy Tarreau
2007-10-16 17:52 ` Pete Zaitcev
2007-10-15 17:30 ` Pete Zaitcev
2007-10-15 20:04 ` Vitaliy Ivanov
2007-10-16 13:48 ` Vitaliy Ivanov
2007-10-16 14:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071019095313.76990765.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=vitalivanov@gmail.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox