From: Sam Ravnborg <sam@ravnborg.org>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: kbuild: kconfig source with " " or not
Date: Sat, 20 Oct 2007 10:13:34 +0200 [thread overview]
Message-ID: <20071020081334.GA5341@uranus.ravnborg.org> (raw)
In-Reply-To: <86802c440710200030y4bdff609m35966a6300f697b2@mail.gmail.com>
Hi Yinghai.
On Sat, Oct 20, 2007 at 12:30:50AM -0700, Yinghai Lu wrote:
> Sam,
>
> in Kconfig, most of source to include other kconfig has "..."
>
> for example:
>
> in arch/x86_64/Kconfig:
> source "net/Kconfig"
>
> but some other don't
>
> < ./drivers/w1/Kconfig:source drivers/w1/masters/Kconfig
> < ./drivers/w1/Kconfig:source drivers/w1/slaves/Kconfig
> < ./drivers/i2c/Kconfig:source drivers/i2c/algos/Kconfig
> < ./drivers/i2c/Kconfig:source drivers/i2c/busses/Kconfig
> < ./drivers/i2c/Kconfig:source drivers/i2c/chips/Kconfig
> < ./arch/frv/Kconfig:source kernel/power/Kconfig
> < ./arch/v850/Kconfig:source init/Kconfig
> < ./arch/v850/Kconfig:source drivers/mtd/Kconfig
> < ./arch/v850/Kconfig:source drivers/parport/Kconfig
> < ./arch/v850/Kconfig:#source drivers/pnp/Kconfig
> < ./arch/v850/Kconfig:source drivers/block/Kconfig
> < ./arch/v850/Kconfig:#source drivers/misc/Config.in
> < ./arch/ia64/Kconfig:source kernel/Kconfig.hz
> < ./arch/i386/Kconfig:source kernel/Kconfig.hz
> < ./arch/i386/Kconfig:source kernel/power/Kconfig
> < ./arch/ppc/Kconfig:source arch/ppc/platforms/4xx/Kconfig
> < ./arch/ppc/Kconfig:source arch/ppc/platforms/85xx/Kconfig
> < ./arch/ppc/Kconfig:source kernel/Kconfig.hz
> < ./arch/ppc/Kconfig:source kernel/Kconfig.preempt
> < ./arch/ppc/Kconfig:source kernel/power/Kconfig
> < ./arch/x86_64/Kconfig:source kernel/Kconfig.hz
> < ./arch/x86_64/Kconfig:source kernel/power/Kconfig
> < ./arch/x86_64/Kconfig:source drivers/Kconfig
> < ./arch/x86_64/Kconfig:source fs/Kconfig
> < ./arch/s390/Kconfig:source kernel/Kconfig.hz
> < ./arch/cris/Kconfig:source mm/Kconfig
> < ./arch/cris/Kconfig:source arch/cris/arch-v10/Kconfig
> < ./arch/cris/Kconfig:source arch/cris/arch-v10/drivers/Kconfig
> < ./arch/cris/Kconfig:#source drivers/misc/Config.in
> < ./arch/powerpc/Kconfig:source kernel/time/Kconfig
> < ./arch/powerpc/Kconfig:source kernel/Kconfig.hz
> < ./arch/powerpc/Kconfig:source kernel/Kconfig.preempt
> < ./arch/powerpc/Kconfig:source kernel/power/Kconfig
> < ./arch/sh64/Kconfig:source init/Kconfig
> < ./arch/sh/Kconfig:source kernel/Kconfig.hz
> < ./arch/sh/Kconfig:source kernel/power/Kconfig
> < ./arch/sparc64/Kconfig:source kernel/Kconfig.hz
> < ./arch/arm/Kconfig:source arch/arm/mm/Kconfig
> < ./arch/blackfin/Kconfig:source kernel/Kconfig.hz
> < ./block/Kconfig:source block/Kconfig.iosched
> < ./security/Kconfig:source security/selinux/Kconfig
>
> better to keep them consistent
Agree - but on the other hand we do not want an all-over-the-tree
patch to fix it up.
If you are up to fix it then please send the patches to the
relevant subsystem/arch maintainers.
When we are almost done we could let kconfig warn if "" is missing.
PS. Added linux-kbuild@vger.kernel.org
Sam
prev parent reply other threads:[~2007-10-20 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 7:30 kbuild: kconfig source with " " or not Yinghai Lu
2007-10-20 8:13 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071020081334.GA5341@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox