* kbuild: kconfig source with " " or not
@ 2007-10-20 7:30 Yinghai Lu
2007-10-20 8:13 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Yinghai Lu @ 2007-10-20 7:30 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Linux Kernel Mailing List
Sam,
in Kconfig, most of source to include other kconfig has "..."
for example:
in arch/x86_64/Kconfig:
source "net/Kconfig"
but some other don't
< ./drivers/w1/Kconfig:source drivers/w1/masters/Kconfig
< ./drivers/w1/Kconfig:source drivers/w1/slaves/Kconfig
< ./drivers/i2c/Kconfig:source drivers/i2c/algos/Kconfig
< ./drivers/i2c/Kconfig:source drivers/i2c/busses/Kconfig
< ./drivers/i2c/Kconfig:source drivers/i2c/chips/Kconfig
< ./arch/frv/Kconfig:source kernel/power/Kconfig
< ./arch/v850/Kconfig:source init/Kconfig
< ./arch/v850/Kconfig:source drivers/mtd/Kconfig
< ./arch/v850/Kconfig:source drivers/parport/Kconfig
< ./arch/v850/Kconfig:#source drivers/pnp/Kconfig
< ./arch/v850/Kconfig:source drivers/block/Kconfig
< ./arch/v850/Kconfig:#source drivers/misc/Config.in
< ./arch/ia64/Kconfig:source kernel/Kconfig.hz
< ./arch/i386/Kconfig:source kernel/Kconfig.hz
< ./arch/i386/Kconfig:source kernel/power/Kconfig
< ./arch/ppc/Kconfig:source arch/ppc/platforms/4xx/Kconfig
< ./arch/ppc/Kconfig:source arch/ppc/platforms/85xx/Kconfig
< ./arch/ppc/Kconfig:source kernel/Kconfig.hz
< ./arch/ppc/Kconfig:source kernel/Kconfig.preempt
< ./arch/ppc/Kconfig:source kernel/power/Kconfig
< ./arch/x86_64/Kconfig:source kernel/Kconfig.hz
< ./arch/x86_64/Kconfig:source kernel/power/Kconfig
< ./arch/x86_64/Kconfig:source drivers/Kconfig
< ./arch/x86_64/Kconfig:source fs/Kconfig
< ./arch/s390/Kconfig:source kernel/Kconfig.hz
< ./arch/cris/Kconfig:source mm/Kconfig
< ./arch/cris/Kconfig:source arch/cris/arch-v10/Kconfig
< ./arch/cris/Kconfig:source arch/cris/arch-v10/drivers/Kconfig
< ./arch/cris/Kconfig:#source drivers/misc/Config.in
< ./arch/powerpc/Kconfig:source kernel/time/Kconfig
< ./arch/powerpc/Kconfig:source kernel/Kconfig.hz
< ./arch/powerpc/Kconfig:source kernel/Kconfig.preempt
< ./arch/powerpc/Kconfig:source kernel/power/Kconfig
< ./arch/sh64/Kconfig:source init/Kconfig
< ./arch/sh/Kconfig:source kernel/Kconfig.hz
< ./arch/sh/Kconfig:source kernel/power/Kconfig
< ./arch/sparc64/Kconfig:source kernel/Kconfig.hz
< ./arch/arm/Kconfig:source arch/arm/mm/Kconfig
< ./arch/blackfin/Kconfig:source kernel/Kconfig.hz
< ./block/Kconfig:source block/Kconfig.iosched
< ./security/Kconfig:source security/selinux/Kconfig
better to keep them consistent
YH
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: kbuild: kconfig source with " " or not
2007-10-20 7:30 kbuild: kconfig source with " " or not Yinghai Lu
@ 2007-10-20 8:13 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2007-10-20 8:13 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Linux Kernel Mailing List, linux-kbuild
Hi Yinghai.
On Sat, Oct 20, 2007 at 12:30:50AM -0700, Yinghai Lu wrote:
> Sam,
>
> in Kconfig, most of source to include other kconfig has "..."
>
> for example:
>
> in arch/x86_64/Kconfig:
> source "net/Kconfig"
>
> but some other don't
>
> < ./drivers/w1/Kconfig:source drivers/w1/masters/Kconfig
> < ./drivers/w1/Kconfig:source drivers/w1/slaves/Kconfig
> < ./drivers/i2c/Kconfig:source drivers/i2c/algos/Kconfig
> < ./drivers/i2c/Kconfig:source drivers/i2c/busses/Kconfig
> < ./drivers/i2c/Kconfig:source drivers/i2c/chips/Kconfig
> < ./arch/frv/Kconfig:source kernel/power/Kconfig
> < ./arch/v850/Kconfig:source init/Kconfig
> < ./arch/v850/Kconfig:source drivers/mtd/Kconfig
> < ./arch/v850/Kconfig:source drivers/parport/Kconfig
> < ./arch/v850/Kconfig:#source drivers/pnp/Kconfig
> < ./arch/v850/Kconfig:source drivers/block/Kconfig
> < ./arch/v850/Kconfig:#source drivers/misc/Config.in
> < ./arch/ia64/Kconfig:source kernel/Kconfig.hz
> < ./arch/i386/Kconfig:source kernel/Kconfig.hz
> < ./arch/i386/Kconfig:source kernel/power/Kconfig
> < ./arch/ppc/Kconfig:source arch/ppc/platforms/4xx/Kconfig
> < ./arch/ppc/Kconfig:source arch/ppc/platforms/85xx/Kconfig
> < ./arch/ppc/Kconfig:source kernel/Kconfig.hz
> < ./arch/ppc/Kconfig:source kernel/Kconfig.preempt
> < ./arch/ppc/Kconfig:source kernel/power/Kconfig
> < ./arch/x86_64/Kconfig:source kernel/Kconfig.hz
> < ./arch/x86_64/Kconfig:source kernel/power/Kconfig
> < ./arch/x86_64/Kconfig:source drivers/Kconfig
> < ./arch/x86_64/Kconfig:source fs/Kconfig
> < ./arch/s390/Kconfig:source kernel/Kconfig.hz
> < ./arch/cris/Kconfig:source mm/Kconfig
> < ./arch/cris/Kconfig:source arch/cris/arch-v10/Kconfig
> < ./arch/cris/Kconfig:source arch/cris/arch-v10/drivers/Kconfig
> < ./arch/cris/Kconfig:#source drivers/misc/Config.in
> < ./arch/powerpc/Kconfig:source kernel/time/Kconfig
> < ./arch/powerpc/Kconfig:source kernel/Kconfig.hz
> < ./arch/powerpc/Kconfig:source kernel/Kconfig.preempt
> < ./arch/powerpc/Kconfig:source kernel/power/Kconfig
> < ./arch/sh64/Kconfig:source init/Kconfig
> < ./arch/sh/Kconfig:source kernel/Kconfig.hz
> < ./arch/sh/Kconfig:source kernel/power/Kconfig
> < ./arch/sparc64/Kconfig:source kernel/Kconfig.hz
> < ./arch/arm/Kconfig:source arch/arm/mm/Kconfig
> < ./arch/blackfin/Kconfig:source kernel/Kconfig.hz
> < ./block/Kconfig:source block/Kconfig.iosched
> < ./security/Kconfig:source security/selinux/Kconfig
>
> better to keep them consistent
Agree - but on the other hand we do not want an all-over-the-tree
patch to fix it up.
If you are up to fix it then please send the patches to the
relevant subsystem/arch maintainers.
When we are almost done we could let kconfig warn if "" is missing.
PS. Added linux-kbuild@vger.kernel.org
Sam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-20 8:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-20 7:30 kbuild: kconfig source with " " or not Yinghai Lu
2007-10-20 8:13 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox