From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@linux-foundation.org>, Jens Axboe <axboe@kernel.dk>
Cc: Nick <gentuu@gmail.com>, Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] blk_sync_queue() should cancel request_queue->unplug_work
Date: Sat, 20 Oct 2007 16:20:21 +0400 [thread overview]
Message-ID: <20071020122021.GA2490@tv-sign.ru> (raw)
(untested, needs an explicit ack/nack from maintainer)
blk_sync_queue() cancels the timer, but forgets to cancel the work.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- K/block/ll_rw_blk.c~2_blk 2007-10-13 14:51:42.000000000 +0400
+++ K/block/ll_rw_blk.c 2007-10-20 16:10:08.000000000 +0400
@@ -1723,6 +1723,7 @@ EXPORT_SYMBOL(blk_stop_queue);
void blk_sync_queue(struct request_queue *q)
{
del_timer_sync(&q->unplug_timer);
+ kblockd_flush_work(&q->unplug_work);
}
EXPORT_SYMBOL(blk_sync_queue);
next reply other threads:[~2007-10-20 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 12:20 Oleg Nesterov [this message]
2007-10-21 19:16 ` [PATCH 2/2] blk_sync_queue() should cancel request_queue->unplug_work Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071020122021.GA2490@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=gentuu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox