From: Sam Ravnborg <sam@ravnborg.org>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix
Date: Sat, 20 Oct 2007 15:06:35 +0200 [thread overview]
Message-ID: <20071020130635.GA6855@uranus.ravnborg.org> (raw)
In-Reply-To: <20071020055251.1847823A75A@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
>
> > Is it truly protable with "=" or do we need to be more clever?
>
> I don't know how you managed to get it to work wtih "==".
> String equality should be "=" in all /bin/sh versions.
> It's been that way since it was written in pseudo-Algol.
[sam@neptun kbuild.git]$ if [ "x86_64" == "x86_64" ]; then echo foo; else echo bar; fi
foo
[sam@neptun kbuild.git]$ if [ "x86_64" == "x86_64x" ]; then echo foo; else echo bar; fi
bar
So it works as I expected here.
I will push your fix later today (which I have tested and it works here too).
Sam
prev parent reply other threads:[~2007-10-20 13:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 4:42 [patch 2.6.23-git] toplevel Makefile/depmod bugfix David Brownell
2007-10-20 5:36 ` Sam Ravnborg
2007-10-20 5:44 ` Roland Dreier
2007-10-20 5:52 ` David Brownell
2007-10-20 13:06 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071020130635.GA6855@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox