* [PATCH 2/2] blk_sync_queue() should cancel request_queue->unplug_work
@ 2007-10-20 12:20 Oleg Nesterov
2007-10-21 19:16 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2007-10-20 12:20 UTC (permalink / raw)
To: Andrew Morton, Jens Axboe; +Cc: Nick, Randy Dunlap, linux-kernel
(untested, needs an explicit ack/nack from maintainer)
blk_sync_queue() cancels the timer, but forgets to cancel the work.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- K/block/ll_rw_blk.c~2_blk 2007-10-13 14:51:42.000000000 +0400
+++ K/block/ll_rw_blk.c 2007-10-20 16:10:08.000000000 +0400
@@ -1723,6 +1723,7 @@ EXPORT_SYMBOL(blk_stop_queue);
void blk_sync_queue(struct request_queue *q)
{
del_timer_sync(&q->unplug_timer);
+ kblockd_flush_work(&q->unplug_work);
}
EXPORT_SYMBOL(blk_sync_queue);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] blk_sync_queue() should cancel request_queue->unplug_work
2007-10-20 12:20 [PATCH 2/2] blk_sync_queue() should cancel request_queue->unplug_work Oleg Nesterov
@ 2007-10-21 19:16 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2007-10-21 19:16 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Andrew Morton, Nick, Randy Dunlap, linux-kernel
On Sat, Oct 20 2007, Oleg Nesterov wrote:
> (untested, needs an explicit ack/nack from maintainer)
>
> blk_sync_queue() cancels the timer, but forgets to cancel the work.
Applied 1-2, thanks a lot Oleg.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-21 19:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-20 12:20 [PATCH 2/2] blk_sync_queue() should cancel request_queue->unplug_work Oleg Nesterov
2007-10-21 19:16 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox