From: Adrian Bunk <bunk@kernel.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: char/cyclades.c: inconsequent NULL checking
Date: Mon, 22 Oct 2007 04:47:34 +0200 [thread overview]
Message-ID: <20071022024734.GI30533@stusta.de> (raw)
The Coverity checker spotted the following inconsequent NULL checking in
drivers/char/cyclades.c:
<-- snip -->
...
static void cyz_handle_tx(struct cyclades_port *info,
struct BUF_CTRL __iomem *buf_ctrl)
{
struct cyclades_card *cinfo = info->card;
struct tty_struct *tty = info->tty;
...
if (tty == NULL)
goto ztxdone;
...
tty_wakeup(tty);
...
<-- snip -->
Nothing in cyz_handle_tx() seems to change "tty".
The "tty_wakeup(tty);" was added in commit
ebafeeff0fea029099e9952f233e0794106897a6.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next reply other threads:[~2007-10-22 2:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 2:47 Adrian Bunk [this message]
2007-10-22 19:06 ` char/cyclades.c: inconsequent NULL checking Jiri Slaby
2007-10-22 19:12 ` Jiri Kosina
2007-10-22 19:42 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071022024734.GI30533@stusta.de \
--to=bunk@kernel.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox