Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

Jeremy Fitzhardinge
2007-10-22T23:56:25Z

Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>
>> Ingo Molnar wrote:
>>
>>> we should kill it there too.
>>>
>>> the only place where we should _please_ keep those annotations are for
>>> functions that get called from assembly code. This makes life immensely
>>> easier for -pg (CONFIG_FUNCTION_TRACING) kernels.
>>>
>> Should we re-add them for the function pointers in asm-x86/paravirt.h?
>>
>
> yes, yes, yes. :-) It was a nightmare to sort it out in -rt (and still
> is).

Do you have a patch to do this already?

>> Andi argued we should remove them since x86 is unconditionally regparm
>> now anyway - and they're pretty ugly syntactically.
>>
>
> Sure, it doesnt make things prettier, but i didnt see any particular
> ugliness.

Hm, how can we get gcc to complain about inconsistent use of fastcall?
It doesn't generate any warnings if the function and its pointer are
inconsistent, presumably because everything is regparm(3) anyway...

J