Re: [PATCH] Add bluetooth support to toshiba-acpi driver

[Jonathan McDowell <noodles@earth.li>]

On Mon, Oct 22, 2007 at 07:26:26AM -0400, John Belmonte wrote:
> > This patch adds bluetooth support to the toshiba-acpi driver. I have
> > tried to follow the same format for the /proc/acpi/toshiba/bluetooth
> > file as followed in the thinkpad-acpi driver. In the long term the
> > rfkill infrastructure looks like the way forward for this functionality,
> > but at present it doesn't seem to be suitable.
> >
> > Traditionally the userland "toshset" program would have been used to
> > enable bluetooth, but this requires either CONFIG_TOSHIBA or a patched
> > toshiba-acpi to emulate the /dev/toshiba device. Also toshset doesn't
> > currently run in 64bit mode.
> >
> > Patch has been successfully tested on a Portégé R200 (in 32bit mode) and
> > an R500 (in 64bit mode).
> >
> > Signed-Off-By: Jonathan McDowell <noodles@earth.li>
> 
> The /proc/acpi/toshiba interface should not be expanded-- do not apply
> this patch.  If any patch is applied, it would be to optionally
> implement the generic /dev/toshiba interface so that user space tools
> like toshset can operate.

There's been a patch to add the /dev/toshiba functionality floating
around for at least a year or two. Is there a reason it hasn't already
been applied?

I'm not entirely convinced that userland is the right way to do this
though. In the long run rfkill appears to be the correct generic
infrastructure, but at present it's not able to cope with devices that
don't exist when switched off and I can't find any other users in
mainline anyway. Assuming that changes, would you accept a patch adding
support for it to toshiba-acpi?

J.

-- 
                                            jid: noodles@jabber.earth.li
I had a life once... but now I have a
                                            modem.