Re: + fix-vm_can_nonlinear-check-in-sys_remap_file_pages.patch added to -mm tree

[Andrew Morton <akpm@linux-foundation.org>]

On Mon, 8 Oct 2007 22:40:44 +0400
Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Mon, Oct 08, 2007 at 10:05:40AM -0700, akpm@linux-foundation.org wrote:
> > --- a/mm/fremap.c~fix-vm_can_nonlinear-check-in-sys_remap_file_pages
> > +++ a/mm/fremap.c
> > @@ -160,7 +160,7 @@ asmlinkage long sys_remap_file_pages(uns
> >  	if (vma->vm_private_data && !(vma->vm_flags & VM_NONLINEAR))
> >  		goto out;
> >  
> > -	if (!vma->vm_flags & VM_CAN_NONLINEAR)
> > +	if (!(vma->vm_flags & VM_CAN_NONLINEAR))
> 
> Ick.
> 
> [PATCH] typo time?

I appreciate the patch, but that changelog is just stupid.  Effectively
what it says is "Andrew, you get to type one up".  I'd prefer not to,
please.

> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  drivers/block/paride/pt.c                    |    2 -
>  drivers/block/pktcdvd.c                      |    4 +--
>  drivers/isdn/act2000/module.c                |   22 ++++++++---------
>  drivers/isdn/i4l/isdn_ttyfax.c               |    2 -
>  drivers/isdn/icn/icn.c                       |   22 ++++++++---------
>  drivers/isdn/isdnloop/isdnloop.c             |   16 ++++++------
>  drivers/media/video/pvrusb2/pvrusb2-ctrl.c   |    2 -
>  drivers/net/wireless/airo.c                  |    2 -
>  drivers/net/wireless/atmel.c                 |    2 -
>  drivers/net/wireless/prism54/isl_ioctl.c     |    4 +--
>  drivers/net/wireless/zd1211rw/zd_rf_uw2453.c |    2 -
>  drivers/video/i810/i810_main.c               |    2 -
>  drivers/video/sis/sis_main.c                 |    2 -
>  fs/ocfs2/alloc.c                             |    2 -
>  net/ieee80211/ieee80211_wx.c                 |    2 -
>  15 files changed, 44 insertions(+), 44 deletions(-)

seven different maintainers need to review and ack this.  Sigh.