Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

Andres Salomon
2007-10-18T21:45:24Z

On Thu, 18 Oct 2007 15:51:24 +0200
Florian Fainelli <florian.fainelli@telecomint.eu> wrote:

> This patch adds the generic GPIO support to the x86
> architecture. We do the same as for MIPS, we let
> the machine override the gpio callbacks and provide
> defaults one in mach-generic.
>
[...]
> +
> +int gpio_request(unsigned gpio, const char *label);
> +void gpio_free(unsigned gpio);
> +int gpio_direction_input(unsigned gpio);
> +int gpio_direction_output(unsigned gpio, int value);
> +int gpio_get_value(unsigned gpio);
> +void gpio_set_value(unsigned gpio, int value);
> +int gpio_to_irq(unsigned gpio);
> +int irq_to_gpio(unsigned irq);

While I certainly would like to see a generic GPIO API, this one isn't
really useful for geode GPIOs. It would be nice to have one that did
work for us as well. Unfortunately, I haven't had the chance to give
much thought to this problem yet.