Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

Thomas Gleixner
2007-10-25T08:19:21Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1343 bytes --]

On Mon, 22 Oct 2007, Andres Salomon wrote:
> On Fri, 19 Oct 2007 14:01:56 +0200
> Florian Fainelli <florian.fainelli@telecomint.eu> wrote:
>
> > Hi Andres,
> >
> > Le jeudi 18 octobre 2007, Andres Salomon a écrit :
> > > While I certainly would like to see a generic GPIO API, this one
> > > isn't really useful for geode GPIOs. It would be nice to have one
> > > that did work for us as well. Unfortunately, I haven't had the
> > > chance to give much thought to this problem yet.
> >
> > This one was discussed mostly on the ARM mailing-list and finally
> > made his way to the mainline kernel. Though it lacks some functions
> > to change for instance a entire GPIO line and not a single bit, it is
> > used on ARM and MIPS systems so I would conform with this one for now
> > because it is used by at least two or more architectures.
>
> How does being used on MIPS and ARM make it suitable for x86? If
> you're arguing that other x86 platforms conform to it, and it might be
> useful for them; sure, I'll buy that. That doesn't seem to currently be
> the case, though.

It might be useful for everyone to check, whether the existing GPIO
functionality can be extended, reworked to match the needs of Geode as
well. Extending / reworking an existing interface is definitely
better than adding a new incompatible one.

tglx