Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

Thomas Gleixner
2007-10-25T15:25:16Z

On Thu, 25 Oct 2007, Florian Fainelli wrote:
> > It might be useful for everyone to check, whether the existing GPIO
> > functionality can be extended, reworked to match the needs of Geode as
> > well. Extending / reworking an existing interface is definitely
> > better than adding a new incompatible one.
>
> Of course. Just because Geode is the only x86 potential user of such an API
> does not mean it should impose its design. Remember that this patch is part
> of a serie to add support for the RDC R-321x SoC, which becomes another
> x86-family user.
>
> Looking at what Geode can do, and what RDC can do, I guess there are only few
> functions that are generic, all the drain, multiplexing, direction things are
> only available on the Geode board.

It does not matter whether Geode has 500 functions and RDC has 5. It
matters that we do _not_ want two different APIs which deal with the
same thing, where one can obviously be a subset of the other. So
either we can extend / rework the stuff that both parties are happy or
we are not going to merge either of them.

tglx