From: Dave Jones <davej@redhat.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: CodingStyle nits in sbf.c
Date: Mon, 22 Oct 2007 15:12:24 -0400 [thread overview]
Message-ID: <20071022191224.GA23273@redhat.com> (raw)
misplaced brackets, 80 columns, whitespace.
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/arch/x86/kernel/bootflag.c b/arch/x86/kernel/bootflag.c
index 0b98605..85fc177 100644
--- a/arch/x86/kernel/bootflag.c
+++ b/arch/x86/kernel/bootflag.c
@@ -30,10 +30,9 @@ static int __init parity(u8 v)
int x = 0;
int i;
- for(i=0;i<8;i++)
- {
- x^=(v&1);
- v>>=1;
+ for (i=0; i<8; i++) {
+ x ^= (v & 1);
+ v >>= 1;
}
return x;
}
@@ -41,13 +40,13 @@ static int __init parity(u8 v)
static void __init sbf_write(u8 v)
{
unsigned long flags;
- if(sbf_port != -1)
- {
+ if (sbf_port != -1) {
v &= ~SBF_PARITY;
- if(!parity(v))
+ if (!parity(v))
v|=SBF_PARITY;
- printk(KERN_INFO "Simple Boot Flag at 0x%x set to 0x%x\n", sbf_port, v);
+ printk(KERN_INFO "Simple Boot Flag at 0x%x "
+ "set to 0x%x\n", sbf_port, v);
spin_lock_irqsave(&rtc_lock, flags);
CMOS_WRITE(v, sbf_port);
@@ -59,7 +58,7 @@ static u8 __init sbf_read(void)
{
u8 v;
unsigned long flags;
- if(sbf_port == -1)
+ if (sbf_port == -1)
return 0;
spin_lock_irqsave(&rtc_lock, flags);
v = CMOS_READ(sbf_port);
@@ -69,9 +68,9 @@ static u8 __init sbf_read(void)
static int __init sbf_value_valid(u8 v)
{
- if(v&SBF_RESERVED) /* Reserved bits */
+ if (v & SBF_RESERVED) /* Reserved bits */
return 0;
- if(!parity(v))
+ if (!parity(v))
return 0;
return 1;
}
@@ -79,11 +78,12 @@ static int __init sbf_value_valid(u8 v)
static int __init sbf_init(void)
{
u8 v;
- if(sbf_port == -1)
+ if (sbf_port == -1)
return 0;
v = sbf_read();
- if(!sbf_value_valid(v))
- printk(KERN_WARNING "Simple Boot Flag value 0x%x read from CMOS RAM was invalid\n",v);
+ if (!sbf_value_valid(v))
+ printk(KERN_WARNING "Simple Boot Flag value 0x%x "
+ "read from CMOS RAM was invalid\n",v);
v &= ~SBF_RESERVED;
v &= ~SBF_BOOTING;
--
http://www.codemonkey.org.uk
reply other threads:[~2007-10-22 19:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071022191224.GA23273@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox