From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Al Viro <viro@ftp.linux.org.uk>,
WANG Cong <xiyou.wangcong@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, Nix <nix@esperi.org.uk>,
Jeff Dike <jdike@addtoit.com>,
Paolo Giarrusso <p.giarrusso@gmail.com>,
user-mode-linux-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Rob Landley <rob@landley.net>
Subject: Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.
Date: Tue, 23 Oct 2007 01:19:27 +0200 [thread overview]
Message-ID: <20071022231927.GA30814@elte.hu> (raw)
In-Reply-To: <471D2ECC.6090209@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Ingo Molnar wrote:
> > we should kill it there too.
> >
> > the only place where we should _please_ keep those annotations are for
> > functions that get called from assembly code. This makes life immensely
> > easier for -pg (CONFIG_FUNCTION_TRACING) kernels.
>
> Should we re-add them for the function pointers in asm-x86/paravirt.h?
yes, yes, yes. :-) It was a nightmare to sort it out in -rt (and still
is). It's also good documentation - it pinpoints functions that are
called from assembly.
> Andi argued we should remove them since x86 is unconditionally regparm
> now anyway - and they're pretty ugly syntactically.
Sure, it doesnt make things prettier, but i didnt see any particular
ugliness.
Ingo
next prev parent reply other threads:[~2007-10-22 23:20 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 22:54 User Mode Linux still doesn't build in 2.6.23-final Rob Landley
2007-10-20 0:52 ` [uml-devel] " Paolo Giarrusso
2007-10-20 11:41 ` Nix
2007-10-21 11:48 ` WANG Cong
2007-10-21 13:08 ` Jeff Dike
2007-10-21 13:20 ` WANG Cong
2007-10-21 15:43 ` Al Viro
2007-10-22 4:37 ` WANG Cong
2007-10-22 5:22 ` Al Viro
2007-10-22 6:12 ` WANG Cong
2007-10-22 6:42 ` Nix
2007-10-22 6:52 ` WANG Cong
2007-10-22 6:59 ` Sam Ravnborg
2007-10-22 7:48 ` WANG Cong
2007-10-22 7:58 ` Robert P. J. Day
2007-10-22 11:36 ` Al Viro
2007-10-22 12:25 ` WANG Cong
2007-10-22 12:30 ` Ingo Molnar
2007-10-22 12:39 ` WANG Cong
2007-10-22 12:43 ` Al Viro
2007-10-22 12:45 ` Ingo Molnar
2007-10-22 23:14 ` Jeremy Fitzhardinge
2007-10-22 23:19 ` Ingo Molnar [this message]
2007-10-22 23:26 ` Jeremy Fitzhardinge
2007-10-22 23:56 ` Jeremy Fitzhardinge
2007-10-23 8:45 ` Ingo Molnar
2007-10-23 12:55 ` Andi Kleen
2007-10-23 13:10 ` Ingo Molnar
2007-10-23 14:01 ` Andi Kleen
2007-10-23 14:20 ` Ingo Molnar
2007-10-23 14:31 ` Jeremy Fitzhardinge
2007-10-23 14:47 ` Ingo Molnar
2007-10-23 15:11 ` Adrian Bunk
2007-10-23 14:48 ` Andi Kleen
2007-10-23 15:13 ` Ingo Molnar
2007-10-23 15:44 ` Ingo Molnar
2007-10-23 16:57 ` Andi Kleen
2007-10-23 13:25 ` Adrian Bunk
2007-10-23 14:20 ` Jeremy Fitzhardinge
2007-10-22 15:33 ` Jeff Dike
2007-10-22 7:01 ` Robert P. J. Day
2007-10-22 7:27 ` Al Viro
2007-10-22 20:24 ` Jeff Dike
2007-10-24 15:22 ` Jeff Dike
2007-10-24 16:14 ` Sam Ravnborg
2007-10-24 21:46 ` Rob Landley
2007-10-25 0:43 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071022231927.GA30814@elte.hu \
--to=mingo@elte.hu \
--cc=jdike@addtoit.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nix@esperi.org.uk \
--cc=p.giarrusso@gmail.com \
--cc=rob@landley.net \
--cc=sam@ravnborg.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=viro@ftp.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox