From: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] CFS CGroup: Report usage
Date: Tue, 23 Oct 2007 08:10:36 +0530 [thread overview]
Message-ID: <20071023024036.GC3324@linux.vnet.ibm.com> (raw)
In-Reply-To: <471D4523.4040509@google.com>
On Mon, Oct 22, 2007 at 05:49:39PM -0700, Paul Menage wrote:
> +static u64 cpu_usage_read(struct cgroup *cgrp, struct cftype *cft)
> +{
> + struct task_group *tg = cgroup_tg(cgrp);
> + int i;
> + u64 res = 0;
> + for_each_possible_cpu(i) {
> + unsigned long flags;
> + spin_lock_irqsave(&tg->cfs_rq[i]->rq->lock, flags);
Is the lock absolutely required here?
Hmm .. I hope the cgroup code prevents a task group from being destroyed while
we are still reading a task group's cpu usage. Is that so?
> + res += tg->se[i]->sum_exec_runtime;
> + spin_unlock_irqrestore(&tg->cfs_rq[i]->rq->lock, flags);
> + }
> + /* Convert from ns to ms */
> + do_div(res, 1000000);
> + return res;
> +}
--
Regards,
vatsa
next prev parent reply other threads:[~2007-10-23 2:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 0:49 [PATCH 2/2] CFS CGroup: Report usage Paul Menage
2007-10-23 2:40 ` Srivatsa Vaddagiri [this message]
2007-10-23 6:06 ` Paul Menage
2007-10-23 7:21 ` Paul Menage
2007-10-23 7:49 ` Balbir Singh
2007-10-23 7:53 ` Paul Menage
2007-10-23 7:57 ` Balbir Singh
2007-10-23 8:08 ` Paul Menage
2007-10-23 16:41 ` Srivatsa Vaddagiri
2007-10-23 3:17 ` Balbir Singh
2007-10-23 6:09 ` Paul Menage
2007-10-23 16:43 ` Srivatsa Vaddagiri
2007-10-23 16:47 ` Srivatsa Vaddagiri
2007-10-23 16:41 ` Paul Menage
2007-10-23 17:38 ` Srivatsa Vaddagiri
2007-10-24 2:28 ` Paul Menage
2007-10-24 4:39 ` Srivatsa Vaddagiri
2007-10-26 1:24 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071023024036.GC3324@linux.vnet.ibm.com \
--to=vatsa@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=mingo@elte.hu \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox