From: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] CFS CGroup: Code cleanup
Date: Tue, 23 Oct 2007 08:16:54 +0530 [thread overview]
Message-ID: <20071023024654.GD3324@linux.vnet.ibm.com> (raw)
In-Reply-To: <471D4510.9030200@google.com>
On Mon, Oct 22, 2007 at 05:49:20PM -0700, Paul Menage wrote:
> Clean up some CFS CGroup code
>
> - replace "cont" with "cgrp" in a few places in the CFS cgroup code,
This change looks good to me. Thanks for doing it.
> - use write_uint rather than write for cpu.shares write function
Minor nit: From pov of making this patch series git bisect safe, shouldn't we
be registering a write_uint() handler in this patch as well?
--
Regards,
vatsa
next prev parent reply other threads:[~2007-10-23 2:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 0:49 [PATCH 1/2] CFS CGroup: Code cleanup Paul Menage
2007-10-23 2:46 ` Srivatsa Vaddagiri [this message]
2007-10-23 6:16 ` Paul Menage
2007-10-23 7:42 ` Paul Menage
-- strict thread matches above, loose matches on Subject: below --
2007-10-24 2:32 Paul Menage
2007-10-24 4:45 ` Srivatsa Vaddagiri
2007-10-24 6:50 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071023024654.GD3324@linux.vnet.ibm.com \
--to=vatsa@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=mingo@elte.hu \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox