From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>, RT <linux-rt-users@vger.kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Dmitry Adamushko <dmitry.adamushko@gmail.com>,
Paul Jackson <pj@sgi.com>, Gregory Haskins <ghaskins@novell.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [PATCH -v2 6/7] wake up balance RT
Date: Mon, 22 Oct 2007 22:59:06 -0400 [thread overview]
Message-ID: <20071023032916.963188616@goodmis.org> (raw)
In-Reply-To: 20071023025900.927578809@goodmis.org
[-- Attachment #1: rt-balance-wakeup.patch --]
[-- Type: text/plain, Size: 1881 bytes --]
This patch adds pushing of overloaded RT tasks from a runqueue that is
having tasks (most likely RT tasks) added to the run queue.
TODO: We don't cover the case of waking of new RT tasks (yet).
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/sched.c | 2 ++
kernel/sched_rt.c | 12 ++++++++++++
2 files changed, 14 insertions(+)
Index: linux-test.git/kernel/sched_rt.c
===================================================================
--- linux-test.git.orig/kernel/sched_rt.c 2007-10-22 22:37:28.000000000 -0400
+++ linux-test.git/kernel/sched_rt.c 2007-10-22 22:38:04.000000000 -0400
@@ -559,9 +559,21 @@ static void schedule_tail_balance_rt(str
spin_unlock_irq(&rq->lock);
}
}
+
+static void wakeup_balance_rt(struct rq *rq, struct task_struct *p)
+{
+ if (unlikely(rt_task(p)) &&
+ (p->prio >= rq->curr->prio)) {
+ /* pull_rt_task needs task to be running */
+ p->state = TASK_RUNNING;
+ push_rt_tasks(rq);
+ }
+}
+
#else /* CONFIG_SMP */
# define schedule_tail_balance_rt(rq) do { } while (0)
# define schedule_balance_rt(rq) do { } while (0)
+# define wakeup_balance_rt(rq, p) do { } while (0)
#endif /* CONFIG_SMP */
Index: linux-test.git/kernel/sched.c
===================================================================
--- linux-test.git.orig/kernel/sched.c 2007-10-22 22:37:28.000000000 -0400
+++ linux-test.git/kernel/sched.c 2007-10-22 22:38:04.000000000 -0400
@@ -22,6 +22,7 @@
* by Peter Williams
* 2007-05-06 Interactivity improvements to CFS by Mike Galbraith
* 2007-07-01 Group scheduling enhancements by Srivatsa Vaddagiri
+ * 2007-10-22 RT overload balancing by Steven Rostedt
*/
#include <linux/mm.h>
@@ -1614,6 +1615,7 @@ out_activate:
update_rq_clock(rq);
activate_task(rq, p, 1);
check_preempt_curr(rq, p);
+ wakeup_balance_rt(rq, p);
success = 1;
out_running:
--
next prev parent reply other threads:[~2007-10-23 3:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 2:59 [PATCH -v2 0/7] New RT Task Balancing -v2 Steven Rostedt
2007-10-23 2:59 ` [PATCH -v2 1/7] Add rt_nr_running accounting Steven Rostedt
2007-10-23 2:59 ` [PATCH -v2 2/7] track highest prio queued on runqueue Steven Rostedt
2007-10-23 2:59 ` [PATCH -v2 3/7] push RT tasks Steven Rostedt
2007-10-23 2:59 ` [PATCH -v2 4/7] RT overloaded runqueues accounting Steven Rostedt
2007-10-23 4:17 ` Paul Jackson
2007-10-23 6:11 ` Paul Menage
2007-10-23 6:19 ` Paul Jackson
2007-10-23 13:43 ` Steven Rostedt
2007-10-23 21:46 ` Paul Jackson
2008-01-29 13:00 ` Paul Jackson
2007-10-23 2:59 ` [PATCH -v2 5/7] pull RT tasks Steven Rostedt
2007-10-23 2:59 ` Steven Rostedt [this message]
2007-10-23 2:59 ` [PATCH -v2 7/7] disable CFS RT load balancing Steven Rostedt
2007-10-23 8:39 ` [PATCH -v2 0/7] New RT Task Balancing -v2 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071023032916.963188616@goodmis.org \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=dmitry.adamushko@gmail.com \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pj@sgi.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox