From: Andi Kleen <andi@firstfloor.org>
To: David Chinner <dgc@sgi.com>
Cc: "Andi Kleen" <andi@firstfloor.org>,
"Jeremy Fitzhardinge" <jeremy@goop.org>,
"dean gaudet" <dean@arctic.org>,
"Nick Piggin" <nickpiggin@yahoo.com.au>,
Xen-devel <xen-devel@lists.xensource.com>,
Morten@suse.de,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
Bøgeskov <xen-users@morten.bogeskov.dk>,
xfs@oss.sgi.com, xfs-masters@oss.sgi.com,
"Mark Williamson" <mark.williamson@cl.cam.ac.uk>
Subject: Re: Interaction between Xen and XFS: stray RW mappings
Date: Tue, 23 Oct 2007 11:28:38 +0200 [thread overview]
Message-ID: <20071023092838.GA24536@one.firstfloor.org> (raw)
In-Reply-To: <20071023003641.GF995458@sgi.com>
On Tue, Oct 23, 2007 at 10:36:41AM +1000, David Chinner wrote:
> > That doesn't mean it is correct.
>
> Right, but it also points to the fact that it's not causing problems
> from 99.999% of ppl out there.
So you're waiting for someone to take months to debug this again?
> You mean like vmap() could record the pages passed to it in the area->pages
> array,
The page tables contain pointers to the pages anyways. vunmap() has to walk
them. It would not be very difficult to store them in an array during
the walk.
>
> If we did this, it would probably be best to pass a page release function
> into the vmap or vunmap call - we'd need page_cache_release() called on
> the page rather than __free_page()....
Possible. Normally vmalloc pages should not be in the LRU except yours
so it would be probably fine to just change it.
> The solution belongs behind the vmap/vunmap interface, not in XFS....
You could also just keep the array from map time around yourself.
Then you could do it yourself.
-Andi
next prev parent reply other threads:[~2007-10-23 9:28 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 16:58 Interaction between Xen and XFS: stray RW mappings Jeremy Fitzhardinge
2007-10-12 17:08 ` Jeremy Fitzhardinge
2007-10-14 22:56 ` David Chinner
2007-10-14 23:12 ` Jeremy Fitzhardinge
2007-10-14 23:33 ` David Chinner
2007-10-15 4:15 ` Nick Piggin
2007-10-15 0:57 ` Jeremy Fitzhardinge
2007-10-15 7:26 ` Nick Piggin
2007-10-15 3:42 ` Jeremy Fitzhardinge
2007-10-15 4:11 ` David Chinner
2007-10-15 4:18 ` Jeremy Fitzhardinge
2007-10-15 4:25 ` David Chinner
2007-10-15 8:31 ` [xfs-masters] " Christoph Hellwig
2007-10-22 3:18 ` dean gaudet
2007-10-22 3:34 ` Jeremy Fitzhardinge
2007-10-22 4:28 ` dean gaudet
2007-10-22 4:39 ` Nick Piggin
2007-10-22 18:37 ` Jeremy Fitzhardinge
2007-10-22 18:32 ` Jeremy Fitzhardinge
2007-10-22 13:47 ` Andi Kleen
2007-10-22 18:40 ` Jeremy Fitzhardinge
2007-10-22 19:07 ` Andi Kleen
2007-10-22 19:11 ` Jeremy Fitzhardinge
2007-10-22 22:32 ` David Chinner
2007-10-22 23:35 ` Andi Kleen
2007-10-23 0:16 ` Zachary Amsden
2007-10-23 0:36 ` David Chinner
2007-10-23 7:04 ` [patch] " David Chinner
2007-10-23 9:30 ` Andi Kleen
2007-10-23 12:41 ` David Chinner
2007-10-23 14:33 ` Jeremy Fitzhardinge
2007-10-24 4:36 ` [PATCH] Allow lazy unmapping by taking extra page references V2 David Chinner
2007-10-24 5:08 ` Jeremy Fitzhardinge
2007-10-24 21:48 ` [PATCH] Allow lazy unmapping by taking extra page references V3 David Chinner
2007-10-24 22:46 ` Jeremy Fitzhardinge
2007-10-24 23:21 ` David Chinner
2007-10-23 9:28 ` Andi Kleen [this message]
2007-10-15 9:36 ` Interaction between Xen and XFS: stray RW mappings Andi Kleen
2007-10-15 14:56 ` Nick Piggin
2007-10-15 11:07 ` Andi Kleen
2007-10-15 11:28 ` Nick Piggin
2007-10-15 12:54 ` Andi Kleen
2007-10-21 12:17 ` Dave Airlie
2007-10-21 22:16 ` Benjamin Herrenschmidt
2007-10-22 9:49 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071023092838.GA24536@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=Morten@suse.de \
--cc=dean@arctic.org \
--cc=dgc@sgi.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.williamson@cl.cam.ac.uk \
--cc=nickpiggin@yahoo.com.au \
--cc=xen-devel@lists.xensource.com \
--cc=xen-users@morten.bogeskov.dk \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox