* mark irqbalance not-recommended
@ 2007-10-23 11:57 Pavel Machek
2007-10-23 13:05 ` Adrian Bunk
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Pavel Machek @ 2007-10-23 11:57 UTC (permalink / raw)
To: kernel list, Andrew Morton, Arjan van de Ven
Mark CONFIG_IRQBALANCE as not recommended any more. It eats too much
power, and better solutions are available in userspace.
Signed-off-by: Pavel Machek <pavel@suse.cz>
---
commit 2665f7971b5b97830b028308553a78a95c131988
tree e1782cceebfb5900373469c0043d113de88f861f
parent f5085f6ea1c5771708c44a4a42ee217e760ff4a0
author Pavel <pavel@amd.ucw.cz> Tue, 23 Oct 2007 13:56:15 +0200
committer Pavel <pavel@amd.ucw.cz> Tue, 23 Oct 2007 13:56:15 +0200
arch/i386/Kconfig | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
index eba2d88..10f3c38 100644
--- a/arch/i386/Kconfig
+++ b/arch/i386/Kconfig
@@ -779,10 +779,13 @@ config EFI
config IRQBALANCE
bool "Enable kernel irq balancing"
depends on SMP && X86_IO_APIC
- default y
+ default n
help
- The default yes will allow the kernel to do irq load balancing.
- Saying no will keep the kernel from doing irq load balancing.
+ Saying yes will allow the kernel to do irq load balancing;
+ but it generates too many CPU wakeups, eating power, and
+ is better done in userspace.
+
+ Say N.
# turning this on wastes a bunch of space.
# Summit needs it only when NUMA is on
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: mark irqbalance not-recommended
2007-10-23 11:57 mark irqbalance not-recommended Pavel Machek
@ 2007-10-23 13:05 ` Adrian Bunk
2007-10-23 16:00 ` Arjan van de Ven
2007-10-23 20:42 ` Jeff Garzik
2 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2007-10-23 13:05 UTC (permalink / raw)
To: Pavel Machek; +Cc: kernel list, Andrew Morton, Arjan van de Ven
On Tue, Oct 23, 2007 at 01:57:09PM +0200, Pavel Machek wrote:
>
> Mark CONFIG_IRQBALANCE as not recommended any more. It eats too much
> power, and better solutions are available in userspace.
What about additionally a printk() during init and a
feature-removal-schedule.txt entry scheduling removal
one year from now?
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> ---
> commit 2665f7971b5b97830b028308553a78a95c131988
> tree e1782cceebfb5900373469c0043d113de88f861f
> parent f5085f6ea1c5771708c44a4a42ee217e760ff4a0
> author Pavel <pavel@amd.ucw.cz> Tue, 23 Oct 2007 13:56:15 +0200
> committer Pavel <pavel@amd.ucw.cz> Tue, 23 Oct 2007 13:56:15 +0200
>
> arch/i386/Kconfig | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
> index eba2d88..10f3c38 100644
> --- a/arch/i386/Kconfig
> +++ b/arch/i386/Kconfig
> @@ -779,10 +779,13 @@ config EFI
> config IRQBALANCE
> bool "Enable kernel irq balancing"
If you want people to notice it's deprecated you should add a
" (DEPRECATED)" to the kconfig prompt.
> depends on SMP && X86_IO_APIC
> - default y
> + default n
Please drop the "default n", it has no effect.
> help
> - The default yes will allow the kernel to do irq load balancing.
> - Saying no will keep the kernel from doing irq load balancing.
> + Saying yes will allow the kernel to do irq load balancing;
> + but it generates too many CPU wakeups, eating power, and
> + is better done in userspace.
> +
> + Say N.
>
> # turning this on wastes a bunch of space.
> # Summit needs it only when NUMA is on
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: mark irqbalance not-recommended
2007-10-23 11:57 mark irqbalance not-recommended Pavel Machek
2007-10-23 13:05 ` Adrian Bunk
@ 2007-10-23 16:00 ` Arjan van de Ven
2007-10-23 20:42 ` Jeff Garzik
2 siblings, 0 replies; 4+ messages in thread
From: Arjan van de Ven @ 2007-10-23 16:00 UTC (permalink / raw)
To: Pavel Machek; +Cc: kernel list, Andrew Morton
On Tue, 23 Oct 2007 13:57:09 +0200
Pavel Machek <pavel@ucw.cz> wrote:
>
> Mark CONFIG_IRQBALANCE as not recommended any more. It eats too much
> power, and better solutions are available in userspace.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: mark irqbalance not-recommended
2007-10-23 11:57 mark irqbalance not-recommended Pavel Machek
2007-10-23 13:05 ` Adrian Bunk
2007-10-23 16:00 ` Arjan van de Ven
@ 2007-10-23 20:42 ` Jeff Garzik
2 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2007-10-23 20:42 UTC (permalink / raw)
To: Pavel Machek; +Cc: kernel list, Andrew Morton, Arjan van de Ven
Pavel Machek wrote:
> Mark CONFIG_IRQBALANCE as not recommended any more. It eats too much
> power, and better solutions are available in userspace.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
ACK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-10-23 20:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-23 11:57 mark irqbalance not-recommended Pavel Machek
2007-10-23 13:05 ` Adrian Bunk
2007-10-23 16:00 ` Arjan van de Ven
2007-10-23 20:42 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox