From: Dave Jones <davej@redhat.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Andi Kleen <ak@suse.de>, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] x86 gart: rename symbols only used for the GART implementation
Date: Tue, 23 Oct 2007 13:59:08 -0400 [thread overview]
Message-ID: <20071023175908.GD7793@redhat.com> (raw)
In-Reply-To: <20071023174711.GC6697@amd.com>
On Tue, Oct 23, 2007 at 07:47:11PM +0200, Joerg Roedel wrote:
> On Tue, Oct 23, 2007 at 07:43:47PM +0200, Andi Kleen wrote:
> > On Tuesday 23 October 2007 19:41:33 Joerg Roedel wrote:
> > > This patch renames the 4 symbols iommu_hole_init(), iommu_aperture,
> > > iommu_aperture_allowed, iommu_aperture_disabled.
> > >
> > > It replaces the iommu_ with gart_ in the symbol name. All these symbols are
> > > only used for the GART implementation of IOMMUs.
> >
> > That makes it still potentially conflicting with the AGP GART code.
>
> Maybe yes. But the AGP GART driver conflicts with the GART IOMMU config
> option. So I don't see a problem here.
It shouldn't. It's perfectly feasible to use both IOMMU and GART for AGP at
the same time.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-10-23 17:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 17:41 [PATCH 0/4] x86: some GART cleanups Joerg Roedel
2007-10-23 17:41 ` [PATCH 1/4] x86 gart: rename iommu.h to gart.h Joerg Roedel
2007-10-23 19:06 ` Muli Ben-Yehuda
2007-10-23 17:41 ` [PATCH 2/4] x86 gart: rename CONFIG_IOMMU to CONFIG_GART_IOMMU Joerg Roedel
2007-10-23 19:06 ` Muli Ben-Yehuda
2007-10-23 17:41 ` [PATCH 3/4] x86 gart: make some variables and functions static Joerg Roedel
2007-10-23 19:07 ` Muli Ben-Yehuda
2007-10-23 17:41 ` [PATCH 4/4] x86 gart: rename symbols only used for the GART implementation Joerg Roedel
2007-10-23 17:43 ` Andi Kleen
2007-10-23 17:47 ` Joerg Roedel
2007-10-23 17:59 ` Dave Jones [this message]
2007-10-23 18:04 ` H. Peter Anvin
2007-10-23 18:10 ` Andi Kleen
2007-10-23 19:05 ` Joerg Roedel
2007-10-23 19:18 ` Muli Ben-Yehuda
-- strict thread matches above, loose matches on Subject: below --
2007-10-24 10:49 [PATCH 0/4] x86: some GART cleanups Joerg Roedel
2007-10-24 10:49 ` [PATCH 4/4] x86 gart: rename symbols only used for the GART implementation Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071023175908.GD7793@redhat.com \
--to=davej@redhat.com \
--cc=ak@suse.de \
--cc=hpa@zytor.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox