Re: [PATCH 4/4] x86 gart: rename symbols only used for the GART implementation

Dave Jones
2007-10-23T17:59:32Z

On Tue, Oct 23, 2007 at 07:47:11PM +0200, Joerg Roedel wrote:
> On Tue, Oct 23, 2007 at 07:43:47PM +0200, Andi Kleen wrote:
> > On Tuesday 23 October 2007 19:41:33 Joerg Roedel wrote:
> > > This patch renames the 4 symbols iommu_hole_init(), iommu_aperture,
> > > iommu_aperture_allowed, iommu_aperture_disabled.
> > >
> > > It replaces the iommu_ with gart_ in the symbol name. All these symbols are
> > > only used for the GART implementation of IOMMUs.
> >
> > That makes it still potentially conflicting with the AGP GART code.
>
> Maybe yes. But the AGP GART driver conflicts with the GART IOMMU config
> option. So I don't see a problem here.

It shouldn't. It's perfectly feasible to use both IOMMU and GART for AGP at
the same time.

Dave

--